[event-hubs] add downleveled types #8654
Conversation
chradek
requested review from
bterlson,
ramya-rao-a and
richardpark-msft
as code owners
| "types/latest/", | ||
| "types/3.1/", |
There was a problem hiding this comment.
Just came across this..
Seems like your current change fixes it.
But we might have missed it in the other packages..
There was a problem hiding this comment.
Hmm, we should log an issue to add those, and maybe also see what impact that has on our docs. I'm betting that TypeDoc either doesn't need it or doesn't use it. I see some other packages like keyvault also only include the bundled types and not the metadata.
There was a problem hiding this comment.
Oh interesting, this seems to be used to by api-extractor so that when it's parsing a package and needs to look at a dependency's types, it can know what dialect of tsdoc was used in the dependency:
microsoft/tsdoc#7
There was a problem hiding this comment.
Created #8662 to track.
| @@ -35,6 +35,6 @@ | |||
| "resolveJsonModule": true | |||
| }, | |||
| "compileOnSave": true, | |||
| "exclude": ["node_modules", "typings/**", "./samples/**/*.ts"], | |||
| "exclude": ["node_modules", "types/**", "./samples/**/*.ts"], | |||
There was a problem hiding this comment.
There must be another tsconfig.json file under samples folder which excludes typings.
There was a problem hiding this comment.
Good catch, updated!
Part of #8275
Also updates the package version to 5.2.0 since the
sendBatchoperation had an additive API change.