Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Arch Board feedback on DPG/ResponseClassifier APIs #27357

Closed
7 of 8 tasks
annelo-msft opened this issue Mar 4, 2022 · 1 comment
Closed
7 of 8 tasks

Address Arch Board feedback on DPG/ResponseClassifier APIs #27357

annelo-msft opened this issue Mar 4, 2022 · 1 comment
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Mar 4, 2022

Arch board issue is here: Azure/azure-sdk#3979
API View is here: Azure.Core 1.23.0 APIView

@annelo-msft annelo-msft added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Mar 4, 2022
@annelo-msft
Copy link
Member Author

Determine whether we can avoid allocating CTS if we only have one CT

Yes, we can: https://docs.microsoft.com/en-us/dotnet/api/system.threading.cancellationtoken.none?view=net-6.0#remarks

  • "Two empty cancellation tokens are always equal."

Therefore we can compare CTs passed into HLC methods to CT.None to determine whether we have two CTs we need to link.

@annelo-msft annelo-msft self-assigned this Mar 4, 2022
@annelo-msft annelo-msft changed the title Address Arch Board feedback on DGP/ResponseClassifier APIs Address Arch Board feedback on DPG/ResponseClassifier APIs Mar 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

1 participant