Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug blocking DPG and update CoreResponseClassifier constructor to take ReadOnlySpan<ushort> #27334

Merged
merged 7 commits into from
Mar 4, 2022

Conversation

annelo-msft
Copy link
Member

@annelo-msft annelo-msft commented Mar 3, 2022

Two changes:

  • We are currently disregarding the ResponseClassifier passed to CreateMessage if RequestContext is null. We need to use it to set the RC and then modify the RC iff RequestContext has modifications.
  • Making a small API update to CoreResponseClassifier per API feedback: update CoreResponseClassifier constructor to take ReadOnlySpan<ushort> to improve perf.

Note: Creating as draft to raise any early concerns and will add tests before taking out of draft

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core. You can review API changes here

API changes

-         public CoreResponseClassifier(ReadOnlySpan<int> nonErrors);
+         public CoreResponseClassifier(ReadOnlySpan<ushort> successCodes);

@annelo-msft annelo-msft marked this pull request as ready for review March 4, 2022 16:58
@annelo-msft annelo-msft requested a review from tg-msft as a code owner March 4, 2022 16:58
@annelo-msft annelo-msft enabled auto-merge (squash) March 4, 2022 17:09
@annelo-msft
Copy link
Member Author

This PR is currently blocked by this: #27350 (comment)

@annelo-msft annelo-msft merged commit 4b1550c into Azure:main Mar 4, 2022
yanfa317 pushed a commit to yanfa317/azure-sdk-for-net that referenced this pull request Mar 8, 2022
… take ReadOnlySpan<ushort> (Azure#27334)

* Fix bug blocking DPG and sm API updates

* export API

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants