-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Make SignedResource not required in listSericeSAS #4615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump the version number to 8.1.1
|
||
2) AutoRest information | ||
Requested version: latest | ||
Bootstrapper version: C:\Users\weiwei\AppData\Roaming\npm `-- [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please pull down the latest changes from psSdkJson6, run msbuild build.proj
and regenerate the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a non breaking change, please bump the version to 8.1.1-preview
533d875
to
837dd3c
Compare
I have update the PR by rebase from psSdkJson6, and regenerate the code.
I also upgrade to 8.1.1, but we won't release SRP SDK for this. will release with next new feature. |
@blueww in case you are not planning to release this version please revert the version back to |
I have reverted the version to 8.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
SignedResource not required in listSericeSAS from server, so set is as not required in swagger/SDK.
Also add description to operation to fix swagger validate failure. (this failure not happen before, might cause by autorest upgrade)
Swagger pass review and merged in Azure/azure-rest-api-specs#3463
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK.