Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Make SignedResource not required in listSericeSAS #4615

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

blueww
Copy link
Member

@blueww blueww commented Aug 1, 2018

Description

SignedResource not required in listSericeSAS from server, so set is as not required in swagger/SDK.
Also add description to operation to fix swagger validate failure. (this failure not happen before, might cause by autorest upgrade)

Swagger pass review and merged in Azure/azure-rest-api-specs#3463

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version number to 8.1.1


2) AutoRest information
Requested version: latest
Bootstrapper version: C:\Users\weiwei\AppData\Roaming\npm `-- [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull down the latest changes from psSdkJson6, run msbuild build.proj and regenerate the code

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a non breaking change, please bump the version to 8.1.1-preview

@blueww blueww force-pushed the fixsas branch 2 times, most recently from 533d875 to 837dd3c Compare August 3, 2018 12:07
@blueww
Copy link
Member Author

blueww commented Aug 3, 2018

@dsgouda

I have update the PR by rebase from psSdkJson6, and regenerate the code.
msbuild build.proj failed with following error. Do you know how to fix it?

c:\code\srpsdk\tools\bootstrapTools\bootstrap.targets(5,4): error : An exception occurred during a WebClient request.

I also upgrade to 8.1.1, but we won't release SRP SDK for this. will release with next new feature.

@dsgouda
Copy link
Contributor

dsgouda commented Aug 3, 2018

@blueww in case you are not planning to release this version please revert the version back to 8.1.0-preview
But please ensure you include these changes in the next PackageReleaseNotes

@blueww
Copy link
Member Author

blueww commented Aug 6, 2018

@dsgouda

I have reverted the version to 8.1.0

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 7b2b907 into Azure:psSdkJson6 Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants