Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Make SignedResource not required in listSericeSAS #4615

Merged
merged 1 commit into from
Aug 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,20 @@ public partial interface IStorageManagementClient : System.IDisposable
string ApiVersion { get; }

/// <summary>
/// Gets or sets the preferred language for the response.
/// The preferred language for the response.
/// </summary>
string AcceptLanguage { get; set; }

/// <summary>
/// Gets or sets the retry timeout in seconds for Long Running
/// Operations. Default value is 30.
/// The retry timeout in seconds for Long Running Operations. Default
/// value is 30.
/// </summary>
int? LongRunningOperationRetryTimeout { get; set; }

/// <summary>
/// When set to true a unique x-ms-client-request-id value is generated
/// and included in each request. Default is true.
/// Whether a unique x-ms-client-request-id should be generated. When
/// set to true a unique x-ms-client-request-id value is generated and
/// included in each request. Default is true.
/// </summary>
bool? GenerateClientRequestId { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@ public OperationDisplay()
/// etc.</param>
/// <param name="operation">Type of operation: get, read, delete,
/// etc.</param>
public OperationDisplay(string provider = default(string), string resource = default(string), string operation = default(string))
/// <param name="description">Description of the operation.</param>
public OperationDisplay(string provider = default(string), string resource = default(string), string operation = default(string), string description = default(string))
{
Provider = provider;
Resource = resource;
Operation = operation;
Description = description;
CustomInit();
}

Expand All @@ -65,5 +67,11 @@ public OperationDisplay()
[JsonProperty(PropertyName = "operation")]
public string Operation { get; set; }

/// <summary>
/// Gets or sets description of the operation.
/// </summary>
[JsonProperty(PropertyName = "description")]
public string Description { get; set; }

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ public Restriction()
/// type is set to location. This would be different locations where
/// the SKU is restricted.</param>
/// <param name="reasonCode">The reason for the restriction. As of now
/// this can be QuotaId or NotAvailableForSubscription. Quota Id is
/// this can be "QuotaId" or "NotAvailableForSubscription". Quota Id is
/// set when the SKU has requiredQuotas parameter as the subscription
/// does not belong to that quota. The NotAvailableForSubscription is
/// does not belong to that quota. The "NotAvailableForSubscription" is
/// related to capacity at DC. Possible values include: 'QuotaId',
/// 'NotAvailableForSubscription'</param>
public Restriction(string type = default(string), IList<string> values = default(IList<string>), string reasonCode = default(string))
Expand Down Expand Up @@ -72,9 +72,9 @@ public Restriction()

/// <summary>
/// Gets or sets the reason for the restriction. As of now this can be
/// QuotaId or NotAvailableForSubscription. Quota Id is set when
/// "QuotaId" or "NotAvailableForSubscription". Quota Id is set when
/// the SKU has requiredQuotas parameter as the subscription does not
/// belong to that quota. The NotAvailableForSubscription is related
/// belong to that quota. The "NotAvailableForSubscription" is related
/// to capacity at DC. Possible values include: 'QuotaId',
/// 'NotAvailableForSubscription'
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public ServiceSasParameters()
/// content language.</param>
/// <param name="contentType">The response header override for content
/// type.</param>
public ServiceSasParameters(string canonicalizedResource, string resource, string permissions = default(string), string iPAddressOrRange = default(string), HttpProtocol? protocols = default(HttpProtocol?), System.DateTime? sharedAccessStartTime = default(System.DateTime?), System.DateTime? sharedAccessExpiryTime = default(System.DateTime?), string identifier = default(string), string partitionKeyStart = default(string), string partitionKeyEnd = default(string), string rowKeyStart = default(string), string rowKeyEnd = default(string), string keyToSign = default(string), string cacheControl = default(string), string contentDisposition = default(string), string contentEncoding = default(string), string contentLanguage = default(string), string contentType = default(string))
public ServiceSasParameters(string canonicalizedResource, string resource = default(string), string permissions = default(string), string iPAddressOrRange = default(string), HttpProtocol? protocols = default(HttpProtocol?), System.DateTime? sharedAccessStartTime = default(System.DateTime?), System.DateTime? sharedAccessExpiryTime = default(System.DateTime?), string identifier = default(string), string partitionKeyStart = default(string), string partitionKeyEnd = default(string), string rowKeyStart = default(string), string rowKeyEnd = default(string), string keyToSign = default(string), string cacheControl = default(string), string contentDisposition = default(string), string contentEncoding = default(string), string contentLanguage = default(string), string contentType = default(string))
{
CanonicalizedResource = canonicalizedResource;
Resource = resource;
Expand Down Expand Up @@ -225,10 +225,6 @@ public virtual void Validate()
{
throw new ValidationException(ValidationRules.CannotBeNull, "CanonicalizedResource");
}
if (Resource == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "Resource");
}
if (Identifier != null)
{
if (Identifier.Length > 64)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,20 @@ public partial class StorageManagementClient : ServiceClient<StorageManagementCl
public string ApiVersion { get; private set; }

/// <summary>
/// Gets or sets the preferred language for the response.
/// The preferred language for the response.
/// </summary>
public string AcceptLanguage { get; set; }

/// <summary>
/// Gets or sets the retry timeout in seconds for Long Running Operations.
/// Default value is 30.
/// The retry timeout in seconds for Long Running Operations. Default value is
/// 30.
/// </summary>
public int? LongRunningOperationRetryTimeout { get; set; }

/// <summary>
/// When set to true a unique x-ms-client-request-id value is generated and
/// included in each request. Default is true.
/// Whether a unique x-ms-client-request-id should be generated. When set to
/// true a unique x-ms-client-request-id value is generated and included in
/// each request. Default is true.
/// </summary>
public bool? GenerateClientRequestId { get; set; }

Expand Down
6 changes: 3 additions & 3 deletions src/SDKs/_metadata/storage_resource-manager.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
2018-06-25 03:10:42 UTC
2018-08-03 12:02:19 UTC

1) azure-rest-api-specs repository information
GitHub user: azure
Branch: master
Commit: 37ca9e71d6c89b46ab990eb064ddb70308fd5824
Commit: d3a52a102020f22da05f40da9c54fc5fb2d93734

2) AutoRest information
Requested version: latest
Bootstrapper version: C:\Users\weiwei\AppData\Roaming\npm `-- [email protected].4280
Bootstrapper version: C:\Users\weiwei\AppData\Roaming\npm `-- [email protected].4283
Latest installed version: