Fix undefined chat thread in main meeting when breakout room is immediately closed #5640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgamis-msft
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
Calling bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
Chat bundle size is decreased✅.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-gxfmqndukw.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
dmceachernmsft
approved these changes
Feb 11, 2025
edwardlee-msft
approved these changes
Feb 11, 2025
mgamis-msft
deleted the
mgamis/fix-chat-thread-breakout-room-is-quickly-closed
branch
mgamis-msft
added a commit
that referenced
this pull request
Feb 11, 2025
…iately closed (#5640) * Fix bug where chat thread is stuck on spinner when breakout room is quickly closed * Fix code comments * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix undefined chat thread in main meeting when breakout room is immediately closed.
The chat state in context is set to undefined when joining a breakout room so as to not show the main meeting chat thread.
The chat state will continue to be undefined until the local user is added to the breakout room chat thread. But when the breakout room is closed immediately the chat state will be stuck as undefined. So when the breakout room is closed we should compare the thread id from the chat state context (which is undefined) to the thread id of the origin call chat adapter.
Why
Bug found during bug bash where we see the chat thread is stuck on spinner when immediately returning to main meeting from a closed breakout room.
How Tested
Tested locally
Process & policy checklist
Is this a breaking change?