Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined chat thread in main meeting when breakout room is immediately closed #5640

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Fix undefined chat thread in main meeting when breakout room is immediately closed #5640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb3ccb7
Fix bug where chat thread is stuck on spinner when breakout room is q…
mgamis-msft Feb 11, 2025
be852ee
Fix code comments
mgamis-msft Feb 11, 2025
edc4e39
Change files
mgamis-msft Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-6ebb0895-7f83-4c53-bb1b-a3dfaa10a46f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Breakout rooms",
"comment": "Fix bug where chat thread is stuck on spinner when immediately returning to main meeting from breakout room",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-6ebb0895-7f83-4c53-bb1b-a3dfaa10a46f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Breakout rooms",
"comment": "Fix bug where chat thread is stuck on spinner when immediately returning to main meeting from breakout room",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 3 additions & 2 deletions ...tes/src/composites/CallWithChatComposite/adapter/AzureCommunicationCallWithChatAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export class AzureCommunicationCallWithChatAdapter implements CallWithChatAdapte
if (!eventData.data || eventData.data.state === 'closed') {
if (
this.originCallChatAdapter &&
this.originCallChatAdapter?.getState().thread.threadId !== this.chatAdapter?.getState().thread.threadId
this.originCallChatAdapter?.getState().thread.threadId !== this.context.getState().chat?.threadId
) {
this.updateChatAdapter(this.originCallChatAdapter);
}
Expand All @@ -222,8 +222,9 @@ export class AzureCommunicationCallWithChatAdapter implements CallWithChatAdapte
this.chatAdapter?.offStateChange(this.onChatStateChange);
// Unassign chat adapter
this.chatAdapter = undefined;
// Set chat state to undefined to prevent showing chat thread of origin call
// Set chat state to undefined to ensure that the chat thread of the breakout room is not shown
this.context.unsetChatState();
// Update chat state to the origin call chat adapter
if (this.originCallChatAdapter) {
this.updateChatAdapter(this.originCallChatAdapter);
}
Expand Down