Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKV imported certificate's order is different with AKV generated certs #136

Closed
JeyJeyGao opened this issue Sep 4, 2023 · 0 comments · Fixed by #135
Closed

AKV imported certificate's order is different with AKV generated certs #136

JeyJeyGao opened this issue Sep 4, 2023 · 0 comments · Fixed by #135
Assignees
@JeyJeyGao
Labels
bug Something isn't working enhancement New feature or request

Comments

@JeyJeyGao
Copy link
Collaborator

If the certificate chain was imported to AKV, the order will not be changed.
If the certificate chain was created by AKV, the chain will be sorted. If it is PEM certificates, the order is from leaf to root. If it is PFX certificates, the order is from root to leaf.

BUG:
Currently, user will confront the issue if their PFX certificate chain was imported to AKV with leaf to root order (only root to leaf order works now).

Feature:
We should support unordered certificate chain.
@JeyJeyGao JeyJeyGao added bug Something isn't working enhancement New feature or request labels Sep 4, 2023
@JeyJeyGao JeyJeyGao self-assigned this Sep 4, 2023
@JeyJeyGao JeyJeyGao mentioned this issue Sep 4, 2023
Merged
JeyJeyGao added a commit that referenced this issue Sep 5, 2023
@JeyJeyGao
fix: certificate path construction (#135)
ae2c91c 
Feat:
- implemented certificate path construction without using built-in
library due to #117

Fix:
- imported PFX certificate chain with leaf to root order doesn't work

Resolves #136 
Signed-off-by: Junjie Gao <[email protected]>

---------

Signed-off-by: Junjie Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeyJeyGao JeyJeyGao

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: certificate path construction JeyJeyGao/notation-azure-kv
1 participant
@JeyJeyGao