fix: remove X509Chain.Build to avoid compatibility issue #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 93.81% 93.97% +0.15%
==========================================
Files 15 15
Lines 469 448 -21
==========================================
- Hits 440 421 -19
+ Misses 29 27 -2
|
JeyJeyGao
added a commit
that referenced
this pull request
Sep 5, 2023
Feat: - implemented certificate path construction without using built-in library due to #117 Fix: - imported PFX certificate chain with leaf to root order doesn't work Resolves #136 Signed-off-by: Junjie Gao <[email protected]> --------- Signed-off-by: Junjie Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the PR, the plugin will not check the certificate chain integrity.
Resolves #116
Signed-off-by: Junjie Gao [email protected]