Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests and Code Coverage #66

Closed
shizhMSFT opened this issue Feb 21, 2023 · 2 comments
Closed

Unit Tests and Code Coverage #66

shizhMSFT opened this issue Feb 21, 2023 · 2 comments
Assignees
@JeyJeyGao
Labels
enhancement New feature or request
Milestone
v1.0.0-rc.1

Comments

@shizhMSFT
Copy link
Member

We should write unit tests to ensure this plugin is at a production level
@shizhMSFT shizhMSFT added the enhancement New feature or request label Feb 21, 2023
@shizhMSFT shizhMSFT added this to the v0.6.0 milestone Feb 21, 2023
@JeyJeyGao JeyJeyGao mentioned this issue Mar 3, 2023
Merged
shizhMSFT pushed a commit that referenced this issue Mar 3, 2023
@JeyJeyGao
test: add keyvault & get metadata unit test (#79)
944aba8 
- refactored for unit test
- get metadata unit test
- keyvault package unit test

Resolve part of #66 

Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao mentioned this issue Mar 8, 2023
Merged
shizhMSFT pushed a commit that referenced this issue Mar 10, 2023
@JeyJeyGao
feat: refactor describe-key command & add unit test (#83)
eccd2c5 
- refactored describe-key command
- added unit test for decribe-key command

Resolve part of #66 

Signed-off-by: Junjie Gao <[email protected]>
@shizhMSFT shizhMSFT modified the milestones: v0.6.0, v1.0.0-rc.1 Apr 27, 2023
@JeyJeyGao
Copy link
Collaborator

The unit test coverage is about 94% now. Can we close the issue? @shizhMSFT

@shizhMSFT
Copy link
Member Author

Closing this issue as code coverage was improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeyJeyGao JeyJeyGao

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0-rc.1
Development

No branches or pull requests
2 participants
@shizhMSFT @JeyJeyGao