Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor describe-key command & add unit test #83

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

JeyJeyGao
Copy link
Collaborator

@JeyJeyGao JeyJeyGao commented Mar 8, 2023

  • refactored describe-key command
  • added unit test for decribe-key command

Resolve part of #66
Signed-off-by: Junjie Gao [email protected]

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@a408db1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e4228ac differs from pull request most recent head 2ff6f5e. Consider uploading reports for the commit 2ff6f5e to get more accurate results

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage        ?   69.60%           
=======================================
  Files           ?        6           
  Lines           ?      306           
  Branches        ?        0           
=======================================
  Hits            ?      213           
  Misses          ?       87           
  Partials        ?        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
@shizhMSFT shizhMSFT self-requested a review March 9, 2023 10:59
Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit eccd2c5 into Azure:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants