Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .browserslistrc and update docs around browser support #3471

Merged
merged 11 commits into from
Apr 15, 2021
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .browserslistrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
last 2 versions
not dead
not ie 11 # Despite this, IE 11 is currently supported but we do not include Promise polyfills
11 changes: 11 additions & 0 deletions build/postinstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,17 @@ if (parseInt(process.env.BEACHBALL)) {
}
});
} else {
// Update caniuse browser db to ensure we're using up to date browserlist
exec("lerna exec \"npx browserslist@latest --update-db\"", function (error, stdout, stderr) {
if (stdout) {
console.log('browserslist update stdout: ' + stdout);
}
console.error('browserslist update stderr: ' + stderr);
if (error !== null) {
console.log('browserslist update exec error: ' + error);
}
});

console.log("Running full bootstrap");
exec("lerna bootstrap", function (error, stdout, stderr) {
if (stdout) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Add .browserslistrc #3471",
"packageName": "@azure/msal-angular",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add .browserslistrc #3471",
"packageName": "@azure/msal-browser",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add .browserslistrc #3471",
"packageName": "@azure/msal-common",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add .browserslistrc #3471",
"packageName": "@azure/msal-node",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Add .browserslistrc #3471",
"packageName": "@azure/msal-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/msal-2a7f03ed-2068-4a29-ac78-e8da746418b2.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add .browserslistrc #3471",
"packageName": "msal",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 3 additions & 2 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@
"exec": {
"scope": [
"msal",
"@azure/msal-angularjs",
"@azure/msal-browser",
"@azure/msal-common",
"@azure/msal-node"
"@azure/msal-node",
"@azure/msal-react",
"@azure/msal-angular"
],
"stream": true
}
Expand Down
5 changes: 5 additions & 0 deletions lib/msal-angular/docs/FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
***
**[Compatibility](#compatibility)**

1. [What browsers are supported?](#what-browsers-are-supported)
1. [What versions of Angular are supported?](#what-versions-of-angular-are-supported)
1. [Does `@azure/msal-angular` support Server Side Rendering?](#does-azuremsal-angular-support-server-side-rendering)
1. [Can `@azure/msal-angular` be used with Internet Explorer?](#can-azuremsal-angular-be-used-with-internet-explorer)
Expand All @@ -28,6 +29,10 @@

## Compatibility

### What browsers are supported?

Please see [here](https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/FAQ.md#what-browsers-are-supported-by-msaljs) for supported browsers.

### What versions of Angular are supported?

Msal Angular currently supports Angular 9, 10, and 11.
Expand Down
95 changes: 50 additions & 45 deletions lib/msal-angular/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion lib/msal-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,6 @@
"resolutions": {
"ini": "^1.3.6",
"object-path": "0.11.5"
}
},
"dependencies": {}
}
31 changes: 25 additions & 6 deletions lib/msal-browser/FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,34 @@

## What browsers are supported by MSAL.js?

MSAL.js has been tested with the following browsers:
MSAL.js has been tested and supports the last 2 stable and supported versions of the following browsers:

IE 11, Edge, Chrome, Firefox and Safari
- Chrome
- Edge (Chromium)
- Firefox
- Safari
- Opera

Keep these steps in mind when [using MSAL.js with IE](https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/Using-msal.js-with-Internet-Explorer).
MSAL.js has also been tested and supports the following browsers with Promise polyfills (not included):

There are certain known issues and mitigations documented for Safari, IE and Edge. Please check out:
* [Known issues on IE and Edge](https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/Known-issues-on-IE-and-Edge-Browser)
* [Known issue on Safari](https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/Known-issue-on-Safari)
- IE 11
- Edge (Legacy)

Keep [these steps](./docs/internet-explorer.md) in mind when using MSAL.js with IE or Edge Legacy. Support for these browsers will be dropped in the next major version of `@azure/msal-browser` (v3).

MSAL.js also supports the following environments:

- WebViews
- Chromium Extensions
- Office Add-ins
- Teams Applications

### Known Issues with Certain Browsers

There are certain known issues and mitigations documented for the following browsers:

- [Browsers that block 3rd Party Cookies (i.e. Safari, Chrome Incognito, Firefox Private)](https://docs.microsoft.com/azure/active-directory/develop/reference-third-party-cookies-spas)
- [IE 11 and Edge Legacy](./docs/internet-explorer.md)

## I am moving from MSAL.js 1.x to MSAL.js to 2.x. What should I know?

Expand Down
Loading