Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6.3 #850

Merged
merged 10 commits into from
Feb 2, 2023
Merged

v0.6.3 #850

merged 10 commits into from
Feb 2, 2023

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Feb 1, 2023

Changes

prepare v0.6.3 release

Checks

  • updated CHANGELOG.md
  • updated doc/
  • update manifest file

create release PR

  • create a PR that finalizes the code for the next version
    • name the PR according to the version vX.Y.Z and add the release
      tag (example here)
    • make sure CHANGELOG.md is up-to-date and enter current date to the release version
    • add summarized release highlights where appropriate
    • update the CITATION.cff version number and date
    • search the project for deprecated and remove deprecated code
  • wait for review and the CI jobs to finish
  • check the readthedocs PR build

Merge the Pull Request

  • merge normally and wait for all CI actions to finish on the main branch

add Git(hub) tag

  • tag and release the current master version on GitHub using the Releases feature
    • name the release git tag according to the version released (e.g. v0.3.3)
    • name the GitHub release accordingly, omitting the v prefix (this can be change later so don't worry, in
      doubt use vX.Y.Z everywhere)
    • copy the changes/release notes of the current version into the description
  • wait for all Github Actions to finish

ReadTheDocs update

  • check the build processes for latest, stable and vX.Y.Z get triggered on RTD (the tag build can get
    triggered twice, resulting in a failed/duplicated build, no need to worry)

pypi release

  • check the automatic release to pypi after the build action completes here

conda-forge release

  • pypi release should get picked up by the conda-forge bot and create the new
    pull-request here
  • carefully check the meta.yaml in the pull request, manually update all changes in the build and run dependencies
  • merge with 2 or more approved reviews

@CagtayFabry CagtayFabry changed the title update manifest v0.6.3 Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Test Results

2 187 tests  ±0   2 186 ✔️ ±0   2m 35s ⏱️ -34s
       1 suites ±0          1 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit e700520. ± Comparison against base commit c04bfda.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #850 (e700520) into master (c04bfda) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #850   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          95       95           
  Lines        6222     6223    +1     
=======================================
+ Hits         6010     6011    +1     
  Misses        212      212           
Impacted Files Coverage Δ
weldx/transformations/cs_manager.py 98.60% <ø> (ø)
weldx/transformations/local_cs.py 96.35% <50.00%> (+0.01%) ⬆️
weldx/asdf/constants.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CagtayFabry CagtayFabry marked this pull request as ready for review February 2, 2023 08:58
@CagtayFabry CagtayFabry requested a review from marscher February 2, 2023 08:59
@marscher
Copy link
Contributor

marscher commented Feb 2, 2023

Why did you need to bump the manifest/extension version? I remember I was struggeling with adding the media_file schema to manifest and had some chat with Volker to resolve it.

@CagtayFabry
Copy link
Member Author

Why did you need to bump the manifest/extension version? I remember I was struggeling with adding the media_file schema to manifest and had some chat with Volker to resolve it.

The manifest (and weldx extension) with version 0.1.1 have already been released in v0.6.2 (or earlier)

In those cases I prefer to create a new version to avoid any confusion and keep the release versions stable

@CagtayFabry CagtayFabry merged commit e7fd50f into master Feb 2, 2023
@CagtayFabry CagtayFabry deleted the v0.6.3 branch February 2, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants