-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Merge updates from BANKEX
Hello @dsemenovsky I'll add this pull request before the 0.3 refactoring, although ABIElement fix may require an extra code change. Sincerely, Alex |
Hi @shamatar After I uncommented your line for tailsPointer in ABIElement, I was still having issues when sending multiple params. I came up with this solution: https://github.com/Vaultie/web3swift/commit/e6d15e74237e50100a847d866147b80478db6f25 It worked for me on the contract methods with params count: 0, 1, 2, 3. Could you give me some comments on this? If it works as supposed to, then maybe you'd like to merge that commit? Best, |
Hello @dsemenovsky I'll have an ABI encoder reworked anyway, to support fixed size arrays of dynamic types and implement experimental ABI version 2 that will come with Solidity 0.5. Although for now all tests have passed and I'll use it as a base. Sincerely, Alex |
@shamatar I mean, this PR doesn't work for me on test environment and I'd like to propose further enhancement, so the library would work with multiple function parameters. There was a difference between input data
method call from Truffle:
I tested and found extra increment for tailsPointer. Without the line in my latest commit it works as expected with different number of parameters. So I'm proposing a PR and waiting for 0.3.0 :) |
Added multiple targets support to use on both iOS and macOS platforms