Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Fix input data generation. Remove tailPointer + h.count line #18

Closed
wants to merge 2 commits into from
Closed

Fix input data generation. Remove tailPointer + h.count line #18

wants to merge 2 commits into from

Conversation

dsemenovsky
Copy link
Contributor

There was a difference between input data
web3swift:

0x3ffbd47f000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000**a0**000000000000000000000000000000000000000000000000000000000000000a7465737420323334323300000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000d7465733233343233343233347400000000000000000000000000000000000000

method call from Truffle:

0x3ffbd47f000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000**80**000000000000000000000000000000000000000000000000000000000000000a7465737420323334323300000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000d7465733233343233343233347400000000000000000000000000000000000000

I tested and found extra increment for tailsPointer. Without the line in my latest commit it works as expected with different number of parameters.

@dsemenovsky dsemenovsky mentioned this pull request Feb 27, 2018
@shamatar
Copy link
Contributor

shamatar commented Mar 1, 2018

Hello @dsemenovsky

I've pushed the new ABI encoder for ABIv1, would you try to run it on your data? It's also test covered now.

Sincerely, Alex

@shamatar
Copy link
Contributor

shamatar commented Mar 1, 2018

@dsemenovsky

Also if you are located in Moscow we are now looking for senior iOS developer, you can mail me if interested.

@dsemenovsky
Copy link
Contributor Author

@shamatar I'd love to chat, but you don't have e-mail in your profile :) How do I get it?

I'll test it today and I'll let you know then

@dsemenovsky
Copy link
Contributor Author

@shamatar You've accidentally merge link to my fork in Readme:

pod 'web3swift', git: 'https://github.com/Vaultie/web3swift.git'

I think you'd like to fix it

@shamatar
Copy link
Contributor

shamatar commented Mar 1, 2018 via email

@shamatar shamatar closed this Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants