Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Most Read not using grid fallback on IE #3234

Closed
1 task
thekp opened this issue Mar 9, 2020 · 0 comments · Fixed by #3237
Closed
1 task

Most Read not using grid fallback on IE #3234

thekp opened this issue Mar 9, 2020 · 0 comments · Fixed by #3237
Assignees
Labels
bug Something isn't working high priority ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team
Milestone

Comments

@thekp
Copy link
Contributor

thekp commented Mar 9, 2020

Describe the bug
Since this PR has been merged: #3200 most read component has been not using the Grid fallback on IE.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to 'https://bbc.github.io/psammead/?path=/story/components-mostread-list--default' on IE browser
  2. See error

Expected behaviour
We expect the Grid component fallback css to be applied, and for most read to have the correct number of columns at the correct viewport. At the moment it's just a single column for all viewports.

When multi column is selected, we expect 5 columns at largest viewport (gel group 5), 2 colums from group 3-4 and one column from group 2 and below.

When twoColumn is selected, we expect 2 columns at largest viewport (gel group 5) to group 3 and one column from group 2 and below

Screenshots
If applicable, add screenshots to help explain your problem.
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Testing notes

  • This bug fix is expected to need manual testing.

Additional context
Add any other context about the problem here.

@thekp thekp added bug Something isn't working ws-home Tasks for the WS Home Team ws-articles Tasks for the WS Articles Team labels Mar 9, 2020
@thekp thekp added this to the Psammead 3.0 milestone Mar 9, 2020
@HarveyPeachey HarveyPeachey self-assigned this Mar 10, 2020
@HarveyPeachey HarveyPeachey mentioned this issue Mar 10, 2020
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working high priority ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants