Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds MostRead to STY's second column #5739

Merged
merged 52 commits into from
Apr 8, 2020
Merged

Adds MostRead to STY's second column #5739

merged 52 commits into from
Apr 8, 2020

Conversation

HarveyPeachey
Copy link
Contributor

@HarveyPeachey HarveyPeachey commented Mar 2, 2020 •
edited
Loading

Resolves #5737

Overall change:
Added MostRead container to STY's second column.

Code changes:

  • Bumped psammead-most-read to version 4.0.2.
  • Bumped psammead-grid to version 1.1.11.
  • Replaced maxTwoColumns boolean with new string prop from most-read.
  • Removed background of STY component wrapper.
  • Updated Snapshots.
  • Added and updated Stories on storybook.
  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing - Regression testing for Front Pages and Articles
  • Dev a11y swarm.

@HarveyPeachey HarveyPeachey added ws-articles Tasks for the WS Articles Team stories-STYs Moving WS STYs to Simorgh labels Mar 2, 2020
@HarveyPeachey HarveyPeachey self-assigned this Mar 2, 2020
@HarveyPeachey HarveyPeachey mentioned this pull request Mar 4, 2020
Merged
3 tasks
EinsteinNjoroge
EinsteinNjoroge reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@EinsteinNjoroge EinsteinNjoroge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions ☝️

HarveyPeachey
HarveyPeachey commented Mar 9, 2020
View reviewed changes
src/app/containers/MostRead/__snapshots__/index.test.jsx.snap
@@ -6,7 +6,7 @@ exports[`MostReadContainerCanonical Assertion should render most read correctly
margin: 0;
padding: 0;
grid-auto-flow: column;
grid-template-rows: repeat( 5,[col-start] auto [col-end] );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit strange that it's changing this value from 5 to 10. Will have to make sure this is double-checked in a11y swarm and test phase.

@thekp
Copy link
Contributor

thekp commented Mar 10, 2020 •
edited
Loading

This issue: BBC-archive/psammead#3234 needs to be resolved before we can merge this PR.
Resolved now.

@HarveyPeachey
Copy link
Contributor Author

HarveyPeachey commented Mar 16, 2020 •
edited
Loading

Dev/A11y Swarm

-https://bbc.github.io/accessibility-news-and-you/accessibility-news-and-testers

  • Axe
  • Design
  • Colour Contrast
  • Colour blindness
  • Windows HCM
  • FF Colour Preferences
  • Text 200%, Page 200%
  • Icons
  • Heading Order
  • Check accesibility of browser DOM
  • Keyboard Navigation

Screen Readers (IE11)

  • ZoomText Magnifier/Reader
  • Dragon NaturallySpeaking
  • JAWS - 4. "Mas Leidas" is read out in English then it reads out "Heading level 2 - Mas leidas" in a Spanish accent.
  • Read&Write - "Mas Leidas" is read out in English then it reads out "Heading level 2 - Mas leidas" in a Spanish accent.
  • NVDA (Firefox) - "Mas Leidas" is read out in English then it reads out "Heading level 2 - Mas leidas" in a Spanish accent.

Mac, iOS, and Android:

  • VoiceOver iOS (iPhone/iPad)
    "Mas Leidas" is read out in Spanish then it reads out "Heading level 2 - Mas leidas" in Spanish.
  • VoiceOver OS (Mac)
  • TalkBack (Chrome on Android)

@lizcameron lizcameron mentioned this pull request Mar 25, 2020
Closed
1 task
@thekp thekp mentioned this pull request Mar 30, 2020
Closed
6 tasks
@paruchurisilpa paruchurisilpa self-assigned this Apr 6, 2020
@sareh sareh added the most-read Tasks to create Most Read component label Apr 6, 2020
@paruchurisilpa
Copy link
Contributor

Looks good to me..

@amywalkerdev amywalkerdev merged commit 9cc9b32 into latest Apr 8, 2020
@amywalkerdev amywalkerdev deleted the most-read-sty-col branch April 8, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EinsteinNjoroge EinsteinNjoroge EinsteinNjoroge left review comments

@hotinglok hotinglok hotinglok left review comments

@j-pendlebury j-pendlebury j-pendlebury approved these changes

@thekp thekp thekp approved these changes

Assignees

@paruchurisilpa paruchurisilpa

@HarveyPeachey HarveyPeachey

Labels
most-read Tasks to create Most Read component stories-STYs Moving WS STYs to Simorgh ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MostRead to STY's secondary column
9 participants
@HarveyPeachey @thekp @paruchurisilpa @j-pendlebury @EinsteinNjoroge @hotinglok @sareh @amywalkerdev @FK78