Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Most Read IE11 Fix #3237

Merged
merged 5 commits into from
Mar 10, 2020
Merged

Most Read IE11 Fix #3237

merged 5 commits into from
Mar 10, 2020

Conversation

HarveyPeachey
Copy link
Contributor

@HarveyPeachey HarveyPeachey commented Mar 10, 2020 •
edited
Loading

Resolves #3234

Overall change: Fixes IE11 column layout fallbacks
Code changes:

  • Fetched list grid props correctly
  • Updated snapshots
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@HarveyPeachey HarveyPeachey added ws-home Tasks for the WS Home Team ws-articles Tasks for the WS Articles Team most-read Tasks to create Most Read component labels Mar 10, 2020
@HarveyPeachey HarveyPeachey self-assigned this Mar 10, 2020
thekp
thekp approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@thekp thekp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

image

@HarveyPeachey HarveyPeachey merged commit 3e46582 into latest Mar 10, 2020
@HarveyPeachey HarveyPeachey deleted the most-read-ie-fix branch March 10, 2020 14:10
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Mar 10, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thekp thekp thekp approved these changes

@hotinglok hotinglok hotinglok approved these changes

Assignees

@HarveyPeachey HarveyPeachey

Labels
most-read Tasks to create Most Read component ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Most Read not using grid fallback on IE
3 participants
@HarveyPeachey @thekp @hotinglok