-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for address discovery #152
Conversation
@teackot what can you say? |
The ec_sys module isn't present on all distributions, for example Fedora doesn't ship it. We have a debug mode in our driver, which dumps the EC ram contents in |
Hi, @teackot, can you check this EC dump method on your devices with both generations. It should workon WMI1 devices, because used in DSDT tables. It reads address
Basically I'm interested is it works on wmi2 |
Hi! Yep it works on my WMI2 Summit E14, gives me a correct EC dump. I'll test in on my P14 a little later Edit: also works on my P14 |
Nice, I'll add this to guide too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions on how to improve the guide
Co-authored-by: teackot <[email protected]>
@teackot I'm thinking about splitting guide into 2 or 3 parts:
|
Co-authored-by: teackot <[email protected]>
So the main one will describe the base principle, the danger, info about the dump, and where and what to look for (aka the known values), etc? This does sound like it should be in this guide. If by splitting you mean to split it into separate files I don't think there is much need, and a single page might be better I'm thinking of a format like this:
|
Okay, known values I'll keep for contribution guide, for example.
Okay, single file guide sounds good. But what we can add to Also, can you start new review and add Alerts tags My own guide making attempt here https://github.com/glpnk/msi-ec/tree/docs/more-docs/docs |
We can put the known values into its own section, since it is likely going to be big.
All sections after the TOC go into it (win, lin, known) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alerts
We can remove the "9. Here you should see a table of all the values your Embedded Chip has in its memory." entry and put the alert it the "reading the table" section. It can go like this:
This way the list won't have anything that breaks the indentation |
Yeah, because we have a second method of reading EC on Win we can split guide to few steps as you said, and apps UPD: I changed heading levels because heading-3 looks unnoticeable |
e8c72f9
to
b7516f4
Compare
docs/device_support_guide.md
Outdated
`/dev/mem` may not be supported on some distros. For details, see `man mem`. | ||
|
||
> [!WARNING] | ||
> Reading random parts of the system memory can reveal your secrets, so check the dump before you post it to Github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and how do i check if the dump i made doesn't include sensitive info? let's call this method "experimental" until we make sure it works no less than 90% of the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, only by comparing with reference dump, like matching the location of the ec name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, chance of getting reading error is higher than accidentally dump some confidential info. And maybe this memory area newer mapped to system RAM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mark it as "Not recommended" and put the warning at the top of this method's section, so it can be the last resort if the two previous methods didn't work for any reason
docs/device_support_guide.md
Outdated
## Windows method (recommended): | ||
# Table of contents (rough) | ||
|
||
+ FW naming and WMI versioning explanation(?) (TODO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is outside the scope of this guide, you've already done a good write up on that topic, so lets keep it outside this guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, this is just a guide on how to obtain and interpret the dump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guide about naming and wmi versions is short, and some people got confused between BIOS and EC names in the past.
And it will be useful to describe known addresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, adding it here as a draft wouldn't hurt, we'll see how well it fits here when the guide is near finished
docs/device_support_guide.md
Outdated
If you need dump in binary form: | ||
|
||
* `cat /sys/kernel/debug/ec/ec0/io > ec_dump.bin` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think anyone does. At least, we don't need binaries submitted here, so let's exclude this part
5812524
to
73ca0ed
Compare
|
||
# Contribution | ||
|
||
## Firmware naming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a solid explanation , but it's better to put it in another documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't need more then 1 guide now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably be in a separate guide.
Some people have been requesting a guide on adding a config to the code and I think it also doesn't belong in this file.
We can make a file with a "Contribution" guide that:
- refers people to this guide if they want to contribute by discovering their laptops' configs (this is a separate file because it is big)
- provides some specific info like FW naming and generations
- explains how to add a config to the code
@teackot do you have access to https://github.com/BeardOverflow/msi-ec/graphs/traffic ? Can you make screenshot of At least I think about the Arch Wiki |
risk management? damage control? whatever you want to call it. if you don't like tip formatting make sure not to make it another ```important``` section, using the same color doesn't attract attention.
Co-authored-by: teackot <[email protected]>
What's left to do here? I think we need to direct people to the issue tracker at the end of the "Windows method" section (like we do in the "Linux method" section) and remove the "Contribution" section (to later move it to a different file as described in this comment), and this PR is good to go |
forgot to create a new branch before i uploaded the file
@teackot only thing left is is to decide where to put links to the guide, my initial thoughts: and this is just enough to attract people's attention. |
more clarification for step 4 EC lockup is when the EC doesn't respond to some MSI settings changes, mainly when changing shift mode and the refresh speed is faster than 400ms in RWEvrything
Now I think that About contribution section - I think info about generations might be useful, but we can call it like |
now it makes more sense to have it as part of the guide
@glpnk for number 2 lets change the wording to "If your device is not in the list, read this guide to get it supported and add it to the list" helpful in case people outside github share the link with each other |
I'm not committed this change, so it's just draft |
because people might figure out the addresses but in the end forget to report them.
Im thinking about adding an explanation about mic/speaker mute LEDs in the Additional Info section; |
LEDs controlled by kernel triggers, which are controlled by audio card drivers. Bluetooth audio works in userspace, so it can't be used as trigger |
@teackot the guide is ready, please go ahead and merge it. |
Thank you very much for writing this important guide! |
And with this, all the open PRs are finally merged |
No description provided.