-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for address discovery #152
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
207c2b4
add contribution guide
mutchiko f1d16ca
Apply suggestions from code review
mutchiko fa5b605
Apply suggestions from @teackot
glpnk 85633e8
Apply suggestions from code review
teackot d111de1
Grammar
teackot 85ae507
add: Linux EC dump guide
glpnk 01588dd
wording correction
mutchiko 502cbae
fix Linux guide
glpnk 030d55f
add: Contribution guides
glpnk 528afcf
corrected a word
mutchiko d71599b
debug mode guide grammar
teackot d6cabc1
Minor edits and grammar
teackot c43ab8f
add tip for BIOS/EC resetting
mutchiko 3ba9695
Added checklist file to be completed by users
mutchiko c96bdec
moved checklist to the right folder
mutchiko b342ab3
Apply suggestions from code review
mutchiko 4f6c97c
Delete docs/features checklist.md
mutchiko f50d599
Update device_support_guide.md
mutchiko 76809ad
change contrubition title to Additional info
mutchiko b076007
reduce table of contents
mutchiko eb3b251
add extra step for windows method
mutchiko 13838d3
use more clear language
mutchiko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a solid explanation , but it's better to put it in another documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't need more then 1 guide now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably be in a separate guide.
Some people have been requesting a guide on adding a config to the code and I think it also doesn't belong in this file.
We can make a file with a "Contribution" guide that: