Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple continuesFroms lead to stackoverflow in IE8 #1523

Closed
thecapdan opened this issue Sep 14, 2015 · 1 comment
Closed

Multiple continuesFroms lead to stackoverflow in IE8 #1523

thecapdan opened this issue Sep 14, 2015 · 1 comment
Labels
Milestone

Comments

@thecapdan
Copy link
Contributor

This is a regression since v0.15.4.

If I am testing a PresentationModel and I have a acceptance tests that contain mutliple continuesFroms, running the tests in IE8 results in a stackoverflow alert.

The failure can be reproduced by adding the following test to our presenter library ATs and running the test in IE8

(function() {
    var GwtTestRunner = require("br/test/GwtTestRunner");
    GwtTestRunner.initialize();

    ddescribe("multiple continue from using a PresentaionModel with an EditableProperty", function() {

        fixtures( require("br/presenter/PresenterFixtureFactory") );

        it("new test", function()
        {
            given("demo.viewOpened = true");
            then("demo.model.plainProperty = 'a'");
        });

        it("new test 2", function()
        {
            given("test.continuesFrom = 'new test'");
            then("demo.model.plainProperty = 'a'");
        });

        it("new test 3", function()
        {
            given("test.continuesFrom = 'new test 2'");
            then("demo.model.plainProperty = 'a'");
        });

        it("new test 4", function()
        {
            given("test.continuesFrom = 'new test 3'");
            then("demo.model.plainProperty = 'a'");
        });

        it("new test 5", function()
        {
            given("test.continuesFrom = 'new test 4'");
            then("demo.model.plainProperty = 'a'");
        });        

        it("new test 6", function()
        {
            given("test.continuesFrom = 'new test 5'");
            then("demo.model.plainProperty = 'a'");
        });   

        it("new test 7", function()
        {
            given("test.continuesFrom = 'new test 6'");
            then("demo.model.plainProperty = 'a'");
        });   

        it("new test 8", function()
        {
            given("test.continuesFrom = 'new test 7'");
            then("demo.model.plainProperty = 'a'");
        });              

        it("new test 9", function()
        {
            given("test.continuesFrom = 'new test 8'");
            then("demo.model.plainProperty = 'a'");
        });  

        it("new test 10", function()
        {
            given("test.continuesFrom = 'new test 9'");
            then("demo.model.plainProperty = 'a'");
        });  

        it("fresh test", function()
        {
            given("demo.viewOpened = true");
            then("demo.model.plainProperty = 'a'");
        });  

        it("fresh test 2", function()
        {
            given("demo.viewOpened = true");
            then("demo.model.plainProperty = 'a'");
        });  

        it("fresh test 3", function()
        {
            given("demo.viewOpened = true");
            then("demo.model.plainProperty = 'a'");
        });  
    });
})();


I tried reproducing this in a GWTestRunner UT (without presenter) using multiple continuesFroms and I was unable to reproduce the stackoverflow

@thecapdan
Copy link
Contributor Author

tests using verifier have sped up dramatically in IE8 following this fix + we no longer get a stackoverflow.

thecapdan added a commit that referenced this issue Sep 22, 2015
…verflow-1523

Multiple continues stackoverflow - fixes #1523
Conflicts:
	brjs-sdk/sdk/libs/javascript/br-presenter/src/br/presenter/component/PresenterComponent.js
	brjs-sdk/sdk/libs/javascript/br-presenter/test-unit/tests/br/presenter/component/PresenterComponentTest.js
	brjs-sdk/sdk/libs/javascript/br-test/test-unit/tests/br/testing/GwtTestRunnerTest.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants