Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple continues stackoverflow - fixes #1523 #1527

Merged
merged 9 commits into from
Sep 18, 2015
Merged

Multiple continues stackoverflow - fixes #1523 #1527

merged 9 commits into from
Sep 18, 2015

Conversation

andy-berry-dev
Copy link
Member

  • adds a test to reproduce the stack overflow issue in IE8 (Multiple continuesFroms lead to stackoverflow in IE8 #1523)
  • change importNode shim so it doesn't use a recursive approach (thanks @dchambers!)
  • change PresenterComponent and KnockoutComponent so they only load an element (and use the above shim) when the element is required to bind the view.

@andy-berry-dev andy-berry-dev added this to the 1.1 milestone Sep 16, 2015
thecapdan added a commit that referenced this pull request Sep 18, 2015
@thecapdan
Merge pull request #1527 from BladeRunnerJS/multiple-continues-stacko…
2f932aa 
…verflow-1523

Multiple continues stackoverflow - fixes #1523
@thecapdan thecapdan merged commit 2f932aa into master Sep 18, 2015
@thecapdan thecapdan deleted the multiple-continues-stackoverflow-1523 branch September 18, 2015 12:51
thecapdan added a commit that referenced this pull request Sep 22, 2015
@thecapdan @dchambers
Merge pull request #1527 from BladeRunnerJS/multiple-continues-stacko…
6de5794 
…verflow-1523

Multiple continues stackoverflow - fixes #1523
Conflicts:
	brjs-sdk/sdk/libs/javascript/br-presenter/src/br/presenter/component/PresenterComponent.js
	brjs-sdk/sdk/libs/javascript/br-presenter/test-unit/tests/br/presenter/component/PresenterComponentTest.js
	brjs-sdk/sdk/libs/javascript/br-test/test-unit/tests/br/testing/GwtTestRunnerTest.js
@JamesSeymour JamesSeymour mentioned this pull request Nov 11, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andy-berry-dev @dchambers @thecapdan