Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review plugin apis 1085 #1277

Merged
merged 153 commits into from
Apr 10, 2015
Merged

Review plugin apis 1085 #1277

merged 153 commits into from
Apr 10, 2015

Conversation

andy-berry-dev
Copy link
Member

PR for #1085.

  • Refactor the API to match the outcome from the plugin review wiki page - https://github.com/BladeRunnerJS/brjs/wiki/Plugin-Interface-Review
  • Make aliasing and services a plugin concern
  • Remove AssetLocations
  • Changes the ordering mechanism to use a priority - this is up for debate since we've said the better way to do this would be to load the active plugins (and the order) from brjs.conf

Andy Berry added 30 commits January 27, 2015 12:02
changes following review of 'CommandPlugin'
32d0588
minor changes to the TagHandlerPlugin interface
33bd0c1
adding a tempdir cleanup step in TemplateUtilityTest
6bd74bf
removing the duplicate seed assets method on several interfaces
2e7dcf5
Merge branch 'develop' into review-plugin-apis-1085
4c818d1
moving some 100% core tests back into brjs-core
88b3bc1
moving more core model tests into brjs-core
f8651ac
AssetLocationPlugin -> LegacyAssetLocationPlugin and adding the new A…
f128bef 
…ssetLocationPlugin interface
removing some uses of .assetLocation("...")
44c8fa7
removing more usage of AssetLocation("...") and moving
0ad02e3 
AliasDefinitionsFile to the AssetContainer
removing the need for a root asset location method on AssetContainer
a1623f0
renaming AssetPlugin to LegacyAssetPlugin
5910993
removing seed asset locations methods
84907b0
moving some plugin tests to a test-integration source location
be32a35
renaming old AbstractAssetLocationPlugin -> AbstractLegacyAssetLocati…
ade45f9 
…onPlugin
temporary changes to model APIs to allow further Asset plugin API cha…
22dcbe4 
…nges
starting to add the new BRJS conformant asset location plugin and Ass…
0336c99 
…etDiscoveryInitiator
removing the need for some classes to refer to the asset location jus…
113b948 
…t to get a CharBufferPool utility
starting to migrate the CommonJS asset plugin to use the new API and …
d3b3cba 
…fleshing out the new discovery mechanism
fleshing out commonjs asset location plugin and fixing some of the fa…
9f9f4bb 
…iling tests
changing the new asset plugin and commonjs source module to return th…
bc36b8a 
…e correct new set of dependent assets
returning the correct asset location from the new source modules unti…
ec581bc 
…l we can remove the method from the interface
fixing some more plugin tests after moving commonjs discovery to the …
ea610b6 
…new API
adding the ability to discover seed assets via the new location API
fbe72b7
starting to move thirdparty asset plugin over to the new API
37de206
making every plugin 'ordered' and replacing it with a more simple pri…
1a235bd 
…ority based system that doesnt encourge plugins to directly depend on one another
renaming the new AssetLocationPlugin -> AssetPlugin since it deals wi…
e506cdf 
…th assets too
fixing priorities to reflect the previous ordering behaviour
afca4cc
creating a unique theme! require path for themes
8976d6c
improving how require prefixes are calculated and passed down the chain
d5baf9b
This was referenced Apr 2, 2015
Closed
Closed
Merged
dchambers added 2 commits April 7, 2015 16:28
@dchambers
Merge branch 'develop' into review-plugin-apis-1085
ccd6921 
Conflicts:
	brjs-core/src/main/java/org/bladerunnerjs/model/NodeImporter.java
	plugins/brjs-plugins/src/test/java/org/bladerunnerjs/spec/command/ImportAppCommandTest.java
@dchambers
Merge branch 'review-plugin-apis-1085' of github.com:BladeRunnerJS/br…
f6f74fd 
…js into review-plugin-apis-1085
@dchambers dchambers mentioned this pull request Apr 8, 2015
Closed
@ccpetercc ccpetercc added 2 - Dev and removed 5 - Test labels Apr 8, 2015
thanhc added a commit that referenced this pull request Apr 10, 2015
@thanhc
Merge pull request #1277 from BladeRunnerJS/review-plugin-apis-1085
22d7c97 
Review plugin apis 1085
@thanhc thanhc merged commit 22d7c97 into develop Apr 10, 2015
@thanhc thanhc deleted the review-plugin-apis-1085 branch April 10, 2015 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@andy-berry-dev @dchambers @thanhc @ccpetercc