OutOfScopeExceptions that list the scope and stricter enforcement so Blades cant depend on Blades in the Aspect scope #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 1, 2015 20:46
|
@andyberry88, am I right in assuming that only the last four commits (#d8c9c60, #482f653, #0cb20d7 & #3646226) needed dev-reviewing? That being the case, this has now been reviewed... |
|
Yep, only the last few commits need reviewing since this branch was based on the API changes branch. |
…efault bladeset were used
ccpetercc
added a commit
that referenced
this pull request
Apr 10, 2015
…32+565 OutOfScopeExceptions that list the scope and stricter enforcement so Blades cant depend on Blades in the Aspect scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1232 and #565.
I've had to add a
Asset.isLogicalAsset()so we can determine whether the enforcement above can be applied as things like Alias assets can depend on assets outside of the scope and the Alias Registry depends on AliasData which is outside of it's scope. @dchambers or @james-shaw-turner can you review this?This is based on the API changes branch (#1277) and should be merged in after that PR.