Renewable capacity map

[victoriahunt]

Pull Request Etiquette doc

Purpose

Map plant capacity, used to show locations of renewables at retirements on scrolly-telling. Relates to Zenhub issue #177. This is basically a restart of PR 180, which i converted to a draft and then got reassigned to other things. There was a desire from the last review to add some pytest type testing to this, which i agree is needed in the long term. I am transitioning at this time to working 100% on the Catalyst project and so am trying to merge in my code quickly. Apologies that I didn't get to the pytests but at this point merging so the code is available for others to use for the dashboard and scrolly-telling is important so I am expediting this PR.

What the code is doing

Code uses the change table from a scenario to identify new plants and then aggregates by coordinates, and maps the plant capacity for those new plants with circle size indicating capacity (pmax).

Testing

manual testing

Where to look

plot_renewable_capacity_map is the location of the function map_plant_capacity. Demo notebook has been added as well, plot_renewable_capacity_map_demo in the demo folder.

Usage Example/Visuals

Time estimate

15 minutes. Code is very straightforward and very similar to carbon emissions plotting code.

[rouille]

The linter fails as you can see. It comes from isort. Below is the error message:

ERROR: /home/runner/work/PostREISE/PostREISE/postreise/plot/plot_renewable_capacity_map.py Imports are incorrectly sorted and/or formatted.
--- /home/runner/work/PostREISE/PostREISE/postreise/plot/plot_renewable_capacity_map.py:before	2020-10-30 02:48:04.612532
+++ /home/runner/work/PostREISE/PostREISE/postreise/plot/plot_renewable_capacity_map.py:after	2020-10-30 02:48:22.960482
@@ -1,10 +1,11 @@
+import pandas as pd
+from bokeh.models import ColumnDataSource, HoverTool
 from bokeh.plotting import figure
-from bokeh.tile_providers import get_provider, Vendors
-from bokeh.models import ColumnDataSource, HoverTool
 from bokeh.sampledata import us_states
+from bokeh.tile_providers import Vendors, get_provider
+
+from postreise.plot.plot_carbon_map import get_borders
 from postreise.plot.projection_helpers import project_bus
-from postreise.plot.plot_carbon_map import get_borders
-import pandas as pd

you need to re-order the import statements as shown above

[rouille]

The plot_renewable_capacity_map module needs to be added to the __all__ variable in the __init__ file

[victoriahunt]

The linter fails as you can see. It comes from isort. Below is the error message:

ERROR: /home/runner/work/PostREISE/PostREISE/postreise/plot/plot_renewable_capacity_map.py Imports are incorrectly sorted and/or formatted.
--- /home/runner/work/PostREISE/PostREISE/postreise/plot/plot_renewable_capacity_map.py:before	2020-10-30 02:48:04.612532
+++ /home/runner/work/PostREISE/PostREISE/postreise/plot/plot_renewable_capacity_map.py:after	2020-10-30 02:48:22.960482
@@ -1,10 +1,11 @@
+import pandas as pd
+from bokeh.models import ColumnDataSource, HoverTool
 from bokeh.plotting import figure
-from bokeh.tile_providers import get_provider, Vendors
-from bokeh.models import ColumnDataSource, HoverTool
 from bokeh.sampledata import us_states
+from bokeh.tile_providers import Vendors, get_provider
+
+from postreise.plot.plot_carbon_map import get_borders
 from postreise.plot.projection_helpers import project_bus
-from postreise.plot.plot_carbon_map import get_borders
-import pandas as pd

you need to re-order the import statements as shown above

reordered with ddc3a00

[victoriahunt]

The plot_renewable_capacity_map module needs to be added to the __all__ variable in the __init__ file

added with 708aa5e

[rouille]

Looks good. Thanks