Implement pie chart generation vs capacity #231
Conversation
| type2color.update(resource_colors) | ||
|
|
||
| grid = Grid(["USA"]) | ||
| id2loadzone = grid.id2zone |
There was a problem hiding this comment.
we will need to refactor that
| "cap": {"label": "Capacity", "unit": "GW", "data": {}}, | ||
| } | ||
| for area, area_type in zip(areas, area_types): | ||
| loadzone_set = area_to_loadzone(grid, area, area_type) |
There was a problem hiding this comment.
we will need to refactor that too
|
Should we have some tests to make sure that the errors are correctly raised and we did not forget any edge cases? |
|
Notebook runs as expected. I would add a main title to mirror what we do in the other ones. |
Tests added. |
A markdown cell in the notebook is added which serves as a main title. |
Pie Pot --> Pie Plot |
BainanXia
force-pushed
the
bainan/multi_pie_chart
branch
from
d05041f to
b8f018d
Compare
Good catch! Fixed. |
rouille
changed the title
Pull Request doc
Purpose
Refactor pie chart plot to remove the dependency of
analyze_pgand other functions/constants inmultifolder.What the code is doing
Implement pie chart plot for generation vs capacity of a list of user specified areas in a list of user specified/customized scenarios
Testing
A demo notebook is added to illustrate the usage.
Where to look
Time estimate
15 min. This one is easier as expected given the major refactor carried out in the previous bar chart PR see 215