Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire analyze_pg and multi folder #243

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

BainanXia
Copy link
Collaborator

Pull Request doc

Purpose

Retire analyze_pg module and everything in multi folder. New functions are implemented to refactor these modules in

What the code is doing

No new code. Deleting all the retired modules + demo notebooks

Testing

All tests still pass.

Where to look

list of files deleted:

  • /postreise/plot/analyze_pg.py
  • /postreise/plot/multi/*
  • /postreise/plot/demo/bar_chart_demo.ipynb
  • /postreise/plot/demo/capacity_factor_demo.ipynb
  • /postreise/plot/demo/generation_stack_area_demo.ipynb
  • /postreise/plot/demo/bar_hbar_pie_shortfall_multi_demo.ipynb

Time estimate

5 min

@BainanXia BainanXia requested a review from rouille March 16, 2021 19:23
@BainanXia BainanXia self-assigned this Mar 16, 2021
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good

@BainanXia BainanXia merged commit 207cba8 into develop Mar 16, 2021
@BainanXia BainanXia deleted the bainan/retire_multi_analyze_pg branch March 16, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants