-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add flexibility to plot_upgrades_map #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenhagg
reviewed
Apr 26, 2021
jenhagg
reviewed
Apr 26, 2021
BainanXia
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic makes sense. Given Research Dan has been testing this for multiple times, I believe this is good to go.
jenhagg
approved these changes
Apr 26, 2021
rouille
reviewed
Apr 26, 2021
rouille
reviewed
Apr 26, 2021
rouille
reviewed
Apr 26, 2021
danielolsen
force-pushed
the
daniel/plot_upgrades_map_flexibility
branch
from
April 26, 2021 20:14
fceff76
to
14e5d6d
Compare
rouille
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Allow transmission upgrades plots to be created using any interconnection, and to properly plot new branches as well as scaled branches.
Closes #267.
What the code is doing
In upgrades.py: we fix the merging of the two branch data frames to ensure that the lat/lon columns of the merged data frame include the lat/lon data of new branches.
In plot_upgrades_map.py:
plot_states
function to simplify border plotting.x_range
andy_range
, to be able to zoom into certain regions.Testing
@danlivengood has been using this code to plot maps of Eastern scenarios with new branches.
Time estimate
10 minutes. The data frame merge is the most complex part, most everything else is just adding flexibility to previously-hardcoded values.