Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge develop into master for v0.5 release #308

Merged
merged 145 commits into from
Sep 1, 2021
Merged

Conversation

danielolsen
Copy link
Contributor

@danielolsen danielolsen commented Jun 11, 2021

Pull Request doc

Purpose

There have been several breaking changes to the PostREISE API (not to mention many new features), so we should probably increment the version accordingly. Closes #298.

Proposed release notes

Closed issues

Merged pull requests (features)

Merged pull requests (fixes, etc.)

Time estimate

5 minutes. We probably want to wait on this until we merge #306 and #307 (maybe more refactoring as well?), but we can at least get the ball rolling.

BainanXia and others added 30 commits March 16, 2021 16:44
* feat: add heatmap plot

* doc: add demo notebook for heatmap plot
…ity_factor

scatter plot capacity vs capacity factor
…ity_curtailment

scatter capacity vs curtailment
…curve_slope

scatter capacity vs cost curve slope
@danielolsen
Copy link
Contributor Author

Once Breakthrough-Energy/PowerSimData#514 is merged, how can we specify in the requirements that we require PowerSimData >= 0.4.3?

@jenhagg
Copy link
Collaborator

jenhagg commented Jun 30, 2021

Once Breakthrough-Energy/PowerSimData#514 is merged, how can we specify in the requirements that we require PowerSimData >= 0.4.3?

Closest think I can think of would be to use the github url as we do in switchwrapper, since develop branch will satisfy the requirement.

@danielolsen
Copy link
Contributor Author

Once Breakthrough-Energy/PowerSimData#514 is merged, how can we specify in the requirements that we require PowerSimData >= 0.4.3?

Closest think I can think of would be to use the github url as we do in switchwrapper, since develop branch will satisfy the requirement.

develop should satisfy the requirement, but we don't need the user to pull the latest PowerSimData every time they want to use PostREISE. Can we specify a particular release in the github URL?

@jenhagg
Copy link
Collaborator

jenhagg commented Jun 30, 2021

Once Breakthrough-Energy/PowerSimData#514 is merged, how can we specify in the requirements that we require PowerSimData >= 0.4.3?

Closest think I can think of would be to use the github url as we do in switchwrapper, since develop branch will satisfy the requirement.

develop should satisfy the requirement, but we don't need the user to pull the latest PowerSimData every time they want to use PostREISE. Can we specify a particular release in the github URL?

Yeah we could specify the git tag, which would be equivalent to powersimdata==0.4.3. If we want >=0.4.3 then using develop or master would work. Actually if we only merge to master on releases, that should be equivalent to how it would work if we had the package on PyPI.

…owersimdata

refactor: replace function definitions with imports from powersimdata
@danielolsen
Copy link
Contributor Author

danielolsen commented Jun 30, 2021

Actually if we only merge to master on releases, that should be equivalent to how it would work if we had the package on PyPI.

I think we want ~=0.4.3, right? Since we may decide to make breaking changes for PowerSimData 0.5.

@jenhagg
Copy link
Collaborator

jenhagg commented Jun 30, 2021

I think we want ~=0.4.3, right? Since we may decide to make breaking changes for PowerSimData 0.5.

That would be ideal. In that case, I guess we could have a stable branch where we exclude patch changes, and have all versioned releases in master. Not sure if it would be easier to just publish to PyPI.

@BainanXia
Copy link
Collaborator

I think we want ~=0.4.3, right? Since we may decide to make breaking changes for PowerSimData 0.5.

That would be ideal. In that case, I guess we could have a stable branch where we exclude patch changes, and have all versioned releases in master. Not sure if it would be easier to just publish to PyPI.

I'm new to package versioning. I could understand if we have all versioned releases in master, it is equivalent to publish to PyPI. But what do you mean by "having a stable branch where we exclude patch changes"?

@jenhagg
Copy link
Collaborator

jenhagg commented Jul 1, 2021

I'm new to package versioning. I could understand if we have all versioned releases in master, it is equivalent to publish to PyPI. But what do you mean by "having a stable branch where we exclude patch changes"?

I was thinking of semver patches, but misspoke - those should be backward compatible. What I meant to say is stable would exclude breaking changes. In any case, this is a temporary solution, since pip can't really do all the version handling without a package server (e.g. PyPI, not sure of other options).

@danielolsen
Copy link
Contributor Author

With #317 getting merged in, I don't think there are any more blockers to this release. I've updated the proposed release notes with the last two months' PRs & issues. Any remaining objections to merging #309 and this PR?

@jenhagg
Copy link
Collaborator

jenhagg commented Sep 1, 2021

With #317 getting merged in, I don't think there are any more blockers to this release. I've updated the proposed release notes with the last two months' PRs & issues. Any remaining objections to merging #309 and this PR?

None from me.

Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you.

@danielolsen danielolsen merged commit 9468af0 into master Sep 1, 2021
@danielolsen danielolsen mentioned this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants