Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add coverage report to pytest #278

Merged
merged 1 commit into from
Apr 30, 2021
Merged

ci: add coverage report to pytest #278

merged 1 commit into from
Apr 30, 2021

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Apr 30, 2021

Purpose

Identical to Breakthrough-Energy/PowerSimData#471 except didn't add python 3.9 testing since pyproj is incompatible, so will address that separately

@jenhagg jenhagg self-assigned this Apr 30, 2021
@jenhagg jenhagg added this to the Let the Sun Shine milestone Apr 30, 2021
@jenhagg jenhagg added the dependencies Pull requests that update a dependency file label Apr 30, 2021
@rouille
Copy link
Collaborator

rouille commented Apr 30, 2021

Ah. 32%.

rouille
rouille approved these changes Apr 30, 2021
View reviewed changes
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is super useful to see where we are lacking

@danielolsen
Copy link
Contributor

It is super useful to see where we are lacking

Pretty much as expected: postreise.analyze is pretty good, but there's almost no coverage of postreise.plot.

@BainanXia
Copy link
Collaborator

It is super useful to see where we are lacking

Pretty much as expected: postreise.analyze is pretty good, but there's almost no coverage of postreise.plot.

Write test functions to run notebooks could increase the coverage of the plot module or we can look into the axes object that the plot function returns.

@jenhagg jenhagg merged commit b4f13a8 into develop Apr 30, 2021
@jenhagg jenhagg deleted the jon/cov branch April 30, 2021 18:05
@danielolsen danielolsen mentioned this pull request Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouille rouille rouille approved these changes

@BainanXia BainanXia Awaiting requested review from BainanXia

@danielolsen danielolsen Awaiting requested review from danielolsen

Assignees

@jenhagg jenhagg

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Let the Sun Shine
Development

Successfully merging this pull request may close these issues.
4 participants
@jenhagg @rouille @danielolsen @BainanXia