Add utilization map to tutorial #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BainanXia
reviewed
May 11, 2021
BainanXia
reviewed
May 11, 2021
docs/plot.rst
Outdated
| from powersimdata.utility.helpers import PrintManager | ||
| from powersimdata.scenario.scenario import Scenario | ||
| from powersimdata import Scenario |
There was a problem hiding this comment.
These two imports, which one should go first or it doesn't matter according to flake8?
There was a problem hiding this comment.
That is a good question. I don't know, what do you think?
There was a problem hiding this comment.
I've no idea. Flake8 is not complaining either way. I guess we are following pep8 only, right? According to style, pep8 enforces groups without enforcing the order within the groups
There was a problem hiding this comment.
I switched it since other code snippets have it first
|
Wrong description of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Add utilization map to tutorial. Closes #290.
What the code is doing
N/A
Testing
Code snippet has been run in the plot_tutorial notebook.
You can run
toxin the docs repository to see the updatesWhere to look
postreise/plot/plot_utilization_mapmodule. Keywords were not correctlypassed toplot_statesfunctionutilization_map_demonotebookTime estimate
5 min