Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bar generation max vs actual vs min #292

Merged
merged 2 commits into from
May 12, 2021
Merged

Conversation

BainanXia
Copy link
Collaborator

Pull Request doc

Purpose

Integrate another plot function from spot check integration notebook, which addresses #263 : bar plot max generation vs actual generation vs minimum generation for any type of resource in a scenario.

What the code is doing

  • Implement plot function plot_bar_generation_max_min_actual.
  • Add demo notebook for the new plot function.

Testing

The plot function calls existing functions in analyze module for calculations.

Where to look

/postreise/plot/plot_bar_generation_max_min_actual.py
/postreise/plot/demo/bar_generation_max_min_actual_demo.ipynb

Usage Example/Visuals

Demos can be found in the demo notebook.

Time estimate

15 min.

@BainanXia BainanXia added the visualization Issue related to visualization label May 12, 2021
@BainanXia BainanXia self-assigned this May 12, 2021
@BainanXia BainanXia force-pushed the bainan/gen_max_min_bar branch from b636e77 to 0d344e7 Compare May 12, 2021 00:20
@BainanXia BainanXia requested review from rouille and danielolsen May 12, 2021 00:21
@BainanXia BainanXia force-pushed the bainan/gen_max_min_bar branch from 0d344e7 to a08b2a0 Compare May 12, 2021 18:34
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@BainanXia BainanXia merged commit 7bc16a7 into develop May 12, 2021
@BainanXia BainanXia deleted the bainan/gen_max_min_bar branch May 12, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visualization Issue related to visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants