Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bar renewable max vs profile vs actual #295

Merged
merged 2 commits into from
May 13, 2021

Conversation

BainanXia
Copy link
Collaborator

Pull Request doc

Purpose

Integrate another plot function from spot check integration notebook, which addresses #264: bar plot total capacity vs available energy vs actual generation for renewable resource in a scenario.

What the code is doing

  • Implement plot function plot_bar_renewable_max_profile_actual.
  • Add demo notebook for the new plot function.

Testing

The plot function calls existing functions in analyze module for calculations.

Where to look

/postreise/plot/plot_bar_renewable_max_profile_actual.py
/postreise/plot/demo/bar_renewable_max_profile_actual_demo.ipynb

Usage Example/Visuals

Demos can be found in the demo notebook.

Time estimate

10 min.

@BainanXia BainanXia added the visualization Issue related to visualization label May 13, 2021
@BainanXia BainanXia requested review from danielolsen and rouille May 13, 2021 18:22
@BainanXia BainanXia self-assigned this May 13, 2021
@rouille
Copy link
Collaborator

rouille commented May 13, 2021

We could have a title in the notebook

@BainanXia BainanXia force-pushed the bainan/renewable_max_profile_actual branch from 52738f2 to d669ab9 Compare May 13, 2021 22:29
@BainanXia
Copy link
Collaborator Author

We could have a title in the notebook

Done.

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@BainanXia BainanXia merged commit 86db80c into develop May 13, 2021
@BainanXia BainanXia deleted the bainan/renewable_max_profile_actual branch May 13, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visualization Issue related to visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants