refactor: move code snippets to files #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouille
reviewed
May 28, 2021
| @@ -0,0 +1,7 @@ | |||
| from bokeh.io import show | |||
| from powersimdata import Scenario | |||
|
|
|||
There was a problem hiding this comment.
It seems I forgot to declare scenario. Can you add scenario = Scenario("3287"). Sorry
|
I imagine |
Actually looks like we only run |
Yeah. Also, I noticed that there was only one new line after the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It should help with simplifying the process to regenerate the plots. Not entirely sure what that looks like yet - ideally something fully automated but more likely just loading the files into a notebook. Either way, the code is more accessible since it's in
.pyfiles and broken up by plot.What the code is doing
Just moving things around, small fix to indentation, and running the formatting on the code.
Testing
Built the docs locally and compared result with the plotting section currently deployed.
Time estimate
10 min