Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Methodology section of transportation electrification #336

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Jan 25, 2023

Pull Request doc

Purpose

Migrate documentation on transportation electrification in the open source docs

What the code is doing

N/A

Testing

N/A

Where to look

Diagrams and tables. Otherwise tplots and text have been copied/pasted. Note that the bibliography is enclosed in a file (refs.bib) in the docs repository (within the ben/transportation). Before mergin transportation_electrification branch into develop, the companion branch in docs will have to be merged

Usage Example/Visuals

Below is a PDF of the PreTREISE part. Check out the methodology section and the bibliography at the end of the document
6. PreREISE — documentation.pdf

Time estimate

20min

@rouille rouille added the documentation Documentation related to package label Jan 25, 2023
@rouille rouille self-assigned this Jan 25, 2023
docs/demand/transportation_electrification/methodology.rst Outdated Show resolved Hide resolved
docs/demand/transportation_electrification/methodology.rst Outdated Show resolved Hide resolved

.. _ldt_smart_charging_output:

.. figure:: demand/transportation_electrification/img/methodology/ldt_smart_charging_output.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, there is a gray border for this figure but not observed in others.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same figure than in the original documentation. I have the source code so I can try to remove the background

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/demand/transportation_electrification/methodology.rst Outdated Show resolved Hide resolved
docs/demand/transportation_electrification/methodology.rst Outdated Show resolved Hide resolved
docs/demand/transportation_electrification/methodology.rst Outdated Show resolved Hide resolved
docs/demand/transportation_electrification/methodology.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related to package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants