Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugs #302

Merged
merged 87 commits into from
Nov 17, 2021
Merged

Fix Bugs #302

merged 87 commits into from
Nov 17, 2021

Conversation

BuffelSaft
Copy link
Owner

Description

Update BE, fix bad egg bug in AI, fix pinch berries.

ultima-soul and others added 30 commits October 6, 2021 10:28
Full credit to Nunuchu42 and cfmnephrite for this code.
Not dealing with Dragon Darts in this PR. Updated waitmessage 0x40 to waitmessage B_WAIT_TIME_LONG.
Missed this change. Tar Shot works perfectly now.
If Tar Shot can't do anything to the target it should fail. Checking this is clunky, but it works.
Fixed two issues:
- Octolock doesn't have an end of turn animation in gen 8
- The def drop anim wasn't played if Sp. Def was at -6 and def could still drop
I broke this while trying to tidy up the code, it worked perfectly before. Also, make sure the "recoil' doesn't break Disguise.
Various bug fixes, syntax corrections etc.
ChangeStatBuffs was missing a check for Big Pecks.
Also removed MOVE_EFFECT_AFFECTS_USER because that shouldn't be part of playstatchangeanimation. The stat drops still bypass Mirror Armor without this.
AsparagusEduardo and others added 26 commits November 13, 2021 10:11
Bypassing screens and protections correctly
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Update Giga Impact's graphic and use fade-in battle animation.
Fix Assault Vest's battle message and effect on Me First
Fix typo that caused infinite loop.
This should ensure that pinch berries confuse the right battler at the right time.
Damage boost should be 33%, not 25%.
Fix Dark Aura and Fairy Aura
Adjusted elements to simplify the conflicts between BE and IE
AI was loading and modifying wrong data in the RAM
…rShouldAvoidHazardsfix

PartyBattlerShouldAvoidHazards fix
Was too high. This doesn't appear to be needed after all but is a good safety measure.
Won't build without also merging the IE
Hold effect name changes, Cmd_handleballthrow, ITEM_ENIGMA_BERRY_E_READER. No longer updating item expansion due to massive conflicts, so no need to have this item from it.
Credit to Kleenexfeu for spotting this mistake. It's very likely this was one of the causes of the bad eggs and other bugs.
This is now implemented, so I've given it back to Koffing and Weezing.
@BuffelSaft BuffelSaft added bug Something isn't working feature Adds new content, mechanics etc. labels Nov 17, 2021
@BuffelSaft BuffelSaft merged commit c50dd60 into master Nov 17, 2021
@BuffelSaft BuffelSaft deleted the bugs branch November 17, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature Adds new content, mechanics etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants