forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bugs #302
Merged
Merged
Fix Bugs #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: LOuroboros <[email protected]>
Co-authored-by: LOuroboros <[email protected]>
Co-authored-by: LOuroboros <[email protected]>
Full credit to Nunuchu42 and cfmnephrite for this code.
Not dealing with Dragon Darts in this PR. Updated waitmessage 0x40 to waitmessage B_WAIT_TIME_LONG.
Missed this change. Tar Shot works perfectly now.
If Tar Shot can't do anything to the target it should fail. Checking this is clunky, but it works.
Fixed two issues: - Octolock doesn't have an end of turn animation in gen 8 - The def drop anim wasn't played if Sp. Def was at -6 and def could still drop
I broke this while trying to tidy up the code, it worked perfectly before. Also, make sure the "recoil' doesn't break Disguise.
…rald-expansion into gen_8_moves_batch1
…rald-expansion into gen_8_moves_batch1
Various bug fixes, syntax corrections etc.
ChangeStatBuffs was missing a check for Big Pecks.
Also removed MOVE_EFFECT_AFFECTS_USER because that shouldn't be part of playstatchangeanimation. The stat drops still bypass Mirror Armor without this.
Bypassing screens and protections correctly
Fixed Relic Song's SE
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Update Giga Impact's graphic and use fade-in battle animation.
wish update
Fix Assault Vest's battle message and effect on Me First
Fix typo that caused infinite loop.
Fix Cherrim softlock
Add Neutralizing Gas
This should ensure that pinch berries confuse the right battler at the right time.
Fix Knock Off, add config
Damage boost should be 33%, not 25%.
Fix Dark Aura and Fairy Aura
Adjusted elements to simplify the conflicts between BE and IE
AI was loading and modifying wrong data in the RAM
…rShouldAvoidHazardsfix PartyBattlerShouldAvoidHazards fix
Was too high. This doesn't appear to be needed after all but is a good safety measure.
Hold effect name changes, Cmd_handleballthrow, ITEM_ENIGMA_BERRY_E_READER. No longer updating item expansion due to massive conflicts, so no need to have this item from it.
Credit to Kleenexfeu for spotting this mistake. It's very likely this was one of the causes of the bad eggs and other bugs.
This is now implemented, so I've given it back to Koffing and Weezing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update BE, fix bad egg bug in AI, fix pinch berries.