-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for terraform-aws-dibbs-ecr-viewer module 0.2.1 #46
Conversation
b2fd3e9
to
97a7c85
Compare
@@ -1,17 +0,0 @@ | |||
terraform { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was removed in favor of adding it to the existing backend.tf
file
97a7c85
to
9059c0e
Compare
9059c0e
to
09b4080
Compare
09b4080
to
109766b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version comment is my only question. Everything else is GTG
@@ -3,10 +3,20 @@ terraform { | |||
required_providers { | |||
aws = { | |||
source = "hashicorp/aws" | |||
version = "=5.70.0" | |||
version = "~> 5.56.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intentionally go down a version for hashicorp/aws?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was intentional! This resolved a conflict with 5.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DEVOPS PULL REQUEST
Related Issue
Changes Proposed
terraform-aws-dibbs-ecr-viewer
module0.1.2
to0.2.1
Additional notes
with internal set to false
: https://github.com/CDCgov/dibbs-aws/actions/runs/11980461986