Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for terraform-aws-dibbs-ecr-viewer module 0.2.1 :shipit: #46

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Nov 20, 2024

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • Updates to consume changes in the terraform-aws-dibbs-ecr-viewer module
  • Added AWS ACM certificate data resource.
  • Updated the ECS module version from 0.1.2 to 0.2.1
  • Added optional configuration for custom domain and metadata database
  • Added new IAM policy actions related to ACM and Secrets Manager

Additional notes

@alismx alismx changed the title update with example of getting a cert to use Cert to enable SSL Nov 21, 2024
@alismx alismx force-pushed the alis/terraform-aws-dibbs-ecr-viewer/issues/8 branch 5 times, most recently from b2fd3e9 to 97a7c85 Compare November 22, 2024 21:59
@@ -1,17 +0,0 @@
terraform {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was removed in favor of adding it to the existing backend.tf file

@alismx alismx force-pushed the alis/terraform-aws-dibbs-ecr-viewer/issues/8 branch from 97a7c85 to 9059c0e Compare November 22, 2024 22:01
@alismx alismx changed the title Cert to enable SSL Cert to enable SSL 🔒 Nov 22, 2024
@alismx alismx changed the title Cert to enable SSL 🔒 Update for terraform-aws-dibbs-ecr-viewer module 0.2.1 :shipit: Nov 22, 2024
@alismx alismx marked this pull request as ready for review November 22, 2024 22:05
@alismx alismx self-assigned this Nov 22, 2024
@alismx alismx force-pushed the alis/terraform-aws-dibbs-ecr-viewer/issues/8 branch from 9059c0e to 09b4080 Compare November 22, 2024 22:10
@alismx alismx force-pushed the alis/terraform-aws-dibbs-ecr-viewer/issues/8 branch from 09b4080 to 109766b Compare November 22, 2024 22:11
Copy link
Collaborator

@shanice-skylight shanice-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version comment is my only question. Everything else is GTG

@@ -3,10 +3,20 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "=5.70.0"
version = "~> 5.56.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally go down a version for hashicorp/aws?

Copy link
Collaborator Author

@alismx alismx Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was intentional! This resolved a conflict with 5.7

Copy link
Collaborator

@shanice-skylight shanice-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alismx alismx merged commit 21325f5 into main Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants