Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for terraform-aws-dibbs-ecr-viewer module 0.2.1 :shipit: #46

Merged
merged 1 commit into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions terraform/implementation/ecs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,29 @@

## Providers

No providers.
| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.56.1 |

## Modules

| Name | Source | Version |
|------|--------|---------|
| <a name="module_ecs"></a> [ecs](#module\_ecs) | CDCgov/dibbs-ecr-viewer/aws | 0.1.2 |
| <a name="module_ecs"></a> [ecs](#module\_ecs) | CDCgov/dibbs-ecr-viewer/aws | 0.2.1 |
| <a name="module_vpc"></a> [vpc](#module\_vpc) | terraform-aws-modules/vpc/aws | 5.16.0 |

## Resources

No resources.
| Name | Type |
|------|------|
| [aws_acm_certificate.this](https://registry.terraform.io/providers/hashicorp/aws/5.56.1/docs/data-sources/acm_certificate) | data source |

## Inputs

| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_availability_zones"></a> [availability\_zones](#input\_availability\_zones) | The availability zones to use | `list(string)` | <pre>[<br> "us-east-1a",<br> "us-east-1b",<br> "us-east-1c"<br>]</pre> | no |
| <a name="input_internal"></a> [internal](#input\_internal) | Flag to determine if the several AWS resources are public (intended for external access, public internet) or private (only intended to be accessed within your AWS VPC or avaiable with other means, a transit gateway for example). | `bool` | `true` | no |
| <a name="input_internal"></a> [internal](#input\_internal) | Flag to determine if the several AWS resources are public (intended for external access, public internet) or private (only intended to be accessed within your AWS VPC or avaiable with other means, a transit gateway for example). | `bool` | `false` | no |
| <a name="input_owner"></a> [owner](#input\_owner) | The owner of the infrastructure | `string` | `"skylight"` | no |
| <a name="input_phdi_version"></a> [phdi\_version](#input\_phdi\_version) | PHDI container image version | `string` | `"v1.6.9"` | no |
| <a name="input_private_subnets"></a> [private\_subnets](#input\_private\_subnets) | The private subnets | `list(string)` | <pre>[<br> "176.24.1.0/24",<br> "176.24.3.0/24"<br>]</pre> | no |
Expand Down
170 changes: 0 additions & 170 deletions terraform/implementation/ecs/SERVICEDATA.md

This file was deleted.

33 changes: 29 additions & 4 deletions terraform/implementation/ecs/main.tf
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
data "aws_acm_certificate" "this" {
domain = "streamline.dibbs.cloud"
types = ["AMAZON_ISSUED"] # or ["ISSUED"] or ["PRIVATE"]
statuses = ["ISSUED"]
}

module "vpc" {
source = "terraform-aws-modules/vpc/aws"
version = "5.16.0"
Expand All @@ -16,7 +22,8 @@ module "vpc" {

module "ecs" {
source = "CDCgov/dibbs-ecr-viewer/aws"
version = "0.1.2"
version = "0.2.1"
# source = "../../../../terraform-aws-dibbs-ecr-viewer"

public_subnet_ids = flatten(module.vpc.public_subnets)
private_subnet_ids = flatten(module.vpc.private_subnets)
Expand All @@ -31,13 +38,31 @@ module "ecs" {
# If intent is to pull from the phdi GHCR, set disable_ecr to true (default is false)
# disable_ecr = true

# If intent is to use the non-integrated viewer, set non_integrated_viewer to "true" (default is false)
# non_integrated_viewer = "true"

# If the intent is to make the ecr-viewer availabble on the public internet, set internal to false (default is true)
# This requires an internet gateway to be present in the VPC.
internal = var.internal

# If the intent is to enable https and port 443, pass the arn of the cert in AWS certificate manager. This cert will be applied to the load balancer. (default is "")
certificate_arn = data.aws_acm_certificate.this.arn

# If the intent is to disable authentication, set ecr_viewer_app_env to "test" (default is "prod")
# ecr_viewer_app_env = "test"

# If intent is to use a metadata database for polutating the ecr-viewer library, setup the database data object to connect to the database (supported databases are postgres and sqlserver)
# Postgresql database example
# postgres_database_data = {
# non_integrated_viewer = "true"
# metadata_database_type = "postgres"
# metadata_database_schema = "core" # (core or extended)
# secrets_manager_postgres_database_url_name = "prod/testSecret"
# }
# SqlServer database example
# sqlserver_database_data = {
# non_integrated_viewer = "true"
# metadata_database_type = "sqlserver"
# metadata_database_schema = "core" # (core or extended)
# secrets_manager_sqlserver_user_name = "prod/testSecret"
# secrets_manager_sqlserver_password_name = "prod/testSecret"
# secrets_manager_sqlserver_host_name = "prod/testSecret"
# }
}
1 change: 0 additions & 1 deletion terraform/implementation/setup/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | ~> 1.9.0 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | =5.70.0 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 5.56.1 |
| <a name="requirement_local"></a> [local](#requirement\_local) | ~> 2.5.0 |
| <a name="requirement_random"></a> [random](#requirement\_random) | ~> 3.6.3 |
Expand Down
12 changes: 11 additions & 1 deletion terraform/implementation/setup/backend.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,20 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "=5.70.0"
version = "~> 5.56.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally go down a version for hashicorp/aws?

Copy link
Collaborator Author

@alismx alismx Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was intentional! This resolved a conflict with 5.7

}
random = {
source = "hashicorp/random"
version = "~> 3.6.3"
}
local = {
source = "hashicorp/local"
version = "~> 2.5.0"
}
}
required_version = "~> 1.9.0"
}

provider "aws" {
region = "us-east-1"
default_tags {
Expand Down
17 changes: 0 additions & 17 deletions terraform/implementation/setup/provider.tf

This file was deleted.

7 changes: 7 additions & 0 deletions terraform/modules/oidc/_data.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ data "aws_iam_policy_document" "storage" {
data "aws_iam_policy_document" "wildcard" {
statement {
actions = [
"acm:ListCertificates",
"acm:DescribeCertificate",
"acm:GetCertificate",
"acm:ListTagsForCertificate",
"ec2:DescribeAddresses",
"ec2:DescribeVpcEndpoints",
"ec2:DescribePrefixLists",
Expand All @@ -76,6 +80,7 @@ data "aws_iam_policy_document" "wildcard" {
"elasticloadbalancing:DescribeTargetGroups",
"iam:ListPolicies",
"route53:CreateHostedZone",
"secretsmanager:GetSecretValue",
]
resources = [
"*"
Expand Down Expand Up @@ -236,10 +241,12 @@ data "aws_iam_policy_document" "resource_tags_update_actions" {
"ec2:AttachInternetGateway",
"ec2:AuthorizeSecurityGroupEgress",
"ec2:AuthorizeSecurityGroupIngress",
"ec2:ReplaceRouteTableAssociation",
"ec2:RevokeSecurityGroupEgress",
"ec2:RevokeSecurityGroupIngress",
"ec2:AssociateRouteTable",
"ec2:ModifyVpcAttribute",
"ec2:CreateTags",
"elasticloadbalancing:AddTags",
"elasticloadbalancing:ModifyLoadBalancerAttributes",
"elasticloadbalancing:ModifyTargetGroupAttributes",
Expand Down