Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove all calls to QT_VERSION_CHECK about Qt5 #8381

Closed
lrineau opened this issue Jul 28, 2024 · 0 comments
Closed

remove all calls to QT_VERSION_CHECK about Qt5 #8381

lrineau opened this issue Jul 28, 2024 · 0 comments
Assignees
@SaillantNicolas
Labels
CGAL 3D demo Cleaning Qt6
Milestone
6.0

Comments

@lrineau
Copy link
Member

lrineau commented Jul 28, 2024

There are still a lot of lines like this in the code:

#if (QT_VERSION >= QT_VERSION_CHECK(5, 13, 0))
//...

Now that CGAL uses Qt6, those conditional blocks are not needed anymore. They should be removed.
@lrineau lrineau added this to the 6.0 milestone Jul 28, 2024
@SaillantNicolas SaillantNicolas mentioned this issue Aug 7, 2024
Merged
sloriot added a commit that referenced this issue Aug 26, 2024
@sloriot
Remove outdated Qt version checks (#8402)
fb9120f 
## Summary of Changes

This PR removes outdated conditional blocks that check for specific Qt
versions since CGAL now uses Qt6 exclusively.

## Release Management

* Issue(s) solved (if any): #8381
@sloriot sloriot closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaillantNicolas SaillantNicolas

Labels
CGAL 3D demo Cleaning Qt6
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
3 participants
@sloriot @lrineau @SaillantNicolas