-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated Qt version checks #8402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloriot
reviewed
Aug 12, 2024
Arrangement_on_surface_2/demo/Arrangement_on_surface_2/CurveInputMethods.cpp
Outdated
Show resolved
Hide resolved
sloriot
reviewed
Aug 19, 2024
sloriot
reviewed
Aug 19, 2024
Arrangement_on_surface_2/demo/Arrangement_on_surface_2/CurveInputMethods.cpp
Outdated
Show resolved
Hide resolved
Successfully tested in CGAL-6.0-Ic-311 |
lrineau
approved these changes
Aug 23, 2024
lrineau
added
the
rm only: ready for master
For the release team only: that indicates that a PR is about to be merged in 'master'
label
Aug 23, 2024
lrineau
removed
the
rm only: ready for master
For the release team only: that indicates that a PR is about to be merged in 'master'
label
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR removes outdated conditional blocks that check for specific Qt versions since CGAL now uses Qt6 exclusively.
Release Management