Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aos_2, AABB_tree: Address warnings #8025

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Conversation

afabri
Copy link
Member

@afabri afabri commented Feb 9, 2024

Summary of Changes

Add a default and copy constructor to fix this warning

Initialize with std::nullopt to try to fix this warning

Also include a on-deprecated boost header.

Release Management

  • Affected package(s): AABB_tree, Arrangement_on_surface_2
  • License and copyright ownership: unchanged

@afabri afabri added Pkg::AABB_tree Pkg::Arrangement_on_surface_2 Warnings For an issue about warnings, or a pull-request that fixes warnings Ready to be tested labels Feb 9, 2024
@afabri afabri added this to the 6.0-beta milestone Feb 9, 2024
@afabri
Copy link
Member Author

afabri commented Feb 14, 2024

Adding the nullopt had no effect. I tend to keep it anyways.

@sloriot sloriot added Batch_1 First Batch of PRs under testing and removed Under Testing labels Feb 15, 2024
@sloriot
Copy link
Member

sloriot commented Feb 16, 2024

Successfully tested in CGA-6.0-Ic-173

@sloriot sloriot added Tested and removed Ready to be tested Batch_1 First Batch of PRs under testing labels Feb 16, 2024
@lrineau lrineau self-assigned this Feb 16, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Feb 16, 2024
@lrineau lrineau merged commit 67474c1 into CGAL:master Feb 16, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Feb 16, 2024
@lrineau lrineau deleted the Aos-warning-GF branch February 16, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged_in_6.0 Pkg::AABB_tree Pkg::Arrangement_on_surface_2 Tested Warnings For an issue about warnings, or a pull-request that fixes warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants