Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aos_2, AABB_tree: Address warnings #8025

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Aos_2, AABB_tree: Address warnings #8025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ac5b7d
Aos: Add default and copy constructor to avoid warning
afabri Feb 9, 2024
790d9ca
Do not include deprecated boost header file
afabri Feb 9, 2024
d12baf7
Try to avoid a non-initialized warning by initializing with std::nullopt
afabri Feb 9, 2024
871a9bb
Follow Laurent's suggestion and remove a =default instead of adding two
afabri Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions AABB_tree/include/CGAL/AABB_tree/internal/AABB_traversal_traits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class First_intersection_traits
Result;
public:
First_intersection_traits(const AABBTraits& traits)
: m_result(), m_traits(traits)
: m_result(std::nullopt), m_traits(traits)
{}

bool go_further() const {
Expand Down Expand Up @@ -202,7 +202,7 @@ class First_primitive_traits
public:
First_primitive_traits(const AABBTraits& traits)
: m_is_found(false)
, m_result()
, m_result(std::nullopt)
, m_traits(traits) {}

bool go_further() const { return !m_is_found; }
Expand Down
2 changes: 1 addition & 1 deletion Arrangement_on_surface_2/demo/Arrangement_on_surface_2/Utils/IntersectCurves.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

#include "IntersectCurves.h"
#include "ArrangementTypes.h"
#include <boost/function_output_iterator.hpp>
#include <boost/iterator/function_output_iterator.hpp>


template <typename Traits_>
Expand Down
2 changes: 0 additions & 2 deletions ...ent_on_surface_2/include/CGAL/Curved_kernel_via_analysis_2/gfx/Curve_renderer_internals.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ struct Pixel_2_
Integer sub_x, sub_y; // subpixel coordinates relative to pixel's boundary
// (always 0 for pixels)

Pixel_2_& operator =(const Pixel_2_& pix) = default;

bool operator ==(const Pixel_2_& pix) const {
return (
x == pix.x && y == pix.y && level == pix.level &&
Expand Down