Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

41 bug bucketsdepositwork return ids=true does not return ids when specified #42

Merged
merged 43 commits into from
Jun 4, 2024
Merged

41 bug bucketsdepositwork return ids=true does not return ids when specified #42

merged 43 commits into from
Jun 4, 2024

Conversation

odarotto
Copy link
Collaborator

@odarotto odarotto commented Jun 4, 2024

No description provided.

odarotto added 30 commits April 26, 2024 11:19
@odarotto
refactor(cli/schedules.py): separating schedules functions from pipel…
e74f45c 
…ines

Schedules client created to handle all operations related to schedules
@odarotto
feat(cli): improvements to pipelines and schedules commands
c286e6e
@odarotto
refactor(schedules.py): adding section when using details option
b794778
@odarotto
feat(variables.py): adding missing statuses
303bb26
@odarotto
feat(cli): adding configs commands
f245508 
confgis commands added so the cli can work with the new version of pipelines(^2.7.0)
@odarotto
refactor(http/configs.py): removing print statement
b7aa758
@odarotto
feat(cli/schedules.py): fixing bad formatting
3918500
@odarotto
fix(cli): addressing comments on PR
253f24d
@odarotto
Merge branch 'main' into 29-feat-apply-changes-to-use-workflow-pipeli…
d1bf596 
…nes270
@odarotto
feat(cli): adding configs commands
3a67136 
confgis commands added so the cli can work with the new version of pipelines(^2.7.0)
@odarotto
refactor(http/configs.py): removing print statement
32cbff9
@odarotto
feat(cli/schedules.py): fixing bad formatting
22d39b9
@odarotto
fix(cli): addressing comments on PR
46b9330
@odarotto
Merge branch '29-feat-apply-changes-to-use-workflow-pipelines270' of h…
3641f11 
…ttps://github.com/CHIMEFRB/workflow into 29-feat-apply-changes-to-use-workflow-pipelines270
@odarotto
test(test_http_context.py): adding tests
e35e658 
Tests added for pipelines client on HTTPContext.
@odarotto
ci(ci.yml): adding steps to tests job
d15735b 
Adding steps for: starting docker services needed for tests; setting development workspace and killing services after tests are completed.
@odarotto
ci(ci.yml): changing docker-compose file name
db3f3ca
@odarotto
ci(ci.yml): adding docker login step
8ffc08b
@odarotto
feat(cli): adding configs commands
f5ab397 
confgis commands added so the cli can work with the new version of pipelines(^2.7.0)
@odarotto
refactor(http/configs.py): removing print statement
f8b1547
@odarotto
feat(cli/schedules.py): fixing bad formatting
25ea648
@odarotto
fix(cli): addressing comments on PR
bb2eda0
@odarotto
feat(cli): improvements to pipelines and schedules commands
7ee34b4
@odarotto
fix(cli): addressing comments on PR
834ca8c
@odarotto
test(test_http_context.py): adding tests
371375a 
Tests added for pipelines client on HTTPContext.
@odarotto
ci(ci.yml): adding steps to tests job
719d85e 
Adding steps for: starting docker services needed for tests; setting development workspace and killing services after tests are completed.
@odarotto
ci(ci.yml): changing docker-compose file name
41b7c92
@odarotto
ci(ci.yml): adding docker login step
4ed4f67
@odarotto
Merge branch '29-feat-apply-changes-to-use-workflow-pipelines270' of h…
c742041 
…ttps://github.com/CHIMEFRB/workflow into 29-feat-apply-changes-to-use-workflow-pipelines270
@odarotto
fix(workflow/utils/read.py): changing active workspace filename
1fd950a
odarotto and others added 11 commits May 29, 2024 13:02
@odarotto
fix(cli/schedules.py): fixing variable name
2463711
@shinybrar
feat(workflow-dev): added workspace configuration for live system tests
b82e437
@shinybrar
fix(http): fixed pipelines,schedules and configs to use baseurls with…
7c4034a 
… prefixing versioning
@shinybrar
fix(workspace-configs): updated workspace configs to point to v2
c34761a
@odarotto
refactor(test_http_context.py): fixing tests
546b06a
@odarotto
Merge branch '29-feat-apply-changes-to-use-workflow-pipelines270' of h…
97ce908 
…ttps://github.com/CHIMEFRB/workflow into 29-feat-apply-changes-to-use-workflow-pipelines270
@odarotto
refactor(workspaces/development.yml): adding version suffix to baseurls
fb99ce2
@odarotto
Retrying
246abd6
@odarotto
fix(docker-compose-tutorial.yml): settings services to latests version
7e06633
@odarotto
fix(docker-compose-tutorial.yml): adding local service
081ef21
@odarotto
fix(http/buckets.py): fixed deposit function
3a2954f 
deposit() function was not using the "return_ids" argument and always returning True, fixed. Tests passing.
@odarotto odarotto requested a review from shinybrar June 4, 2024 12:52
@odarotto odarotto self-assigned this Jun 4, 2024
@odarotto odarotto linked an issue Jun 4, 2024 that may be closed by this pull request
[BUG] Buckets.deposit(work, return_ids=True) does not return IDs when specified #41
Closed
@shinybrar shinybrar merged commit c90bc7a into main Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinybrar shinybrar shinybrar approved these changes

Assignees

@odarotto odarotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Buckets.deposit(work, return_ids=True) does not return IDs when specified
2 participants
@odarotto @shinybrar