Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41 bug bucketsdepositwork return ids=true does not return ids when specified #42

Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
e74f45c
refactor(cli/schedules.py): separating schedules functions from pipel…
odarotto Apr 26, 2024
c286e6e
feat(cli): improvements to pipelines and schedules commands
odarotto Apr 30, 2024
b794778
refactor(schedules.py): adding section when using details option
odarotto May 1, 2024
303bb26
feat(variables.py): adding missing statuses
odarotto May 1, 2024
f245508
feat(cli): adding configs commands
odarotto May 3, 2024
b7aa758
refactor(http/configs.py): removing print statement
odarotto May 3, 2024
3918500
feat(cli/schedules.py): fixing bad formatting
odarotto May 6, 2024
253f24d
fix(cli): addressing comments on PR
odarotto May 10, 2024
d1bf596
Merge branch 'main' into 29-feat-apply-changes-to-use-workflow-pipeli…
odarotto May 13, 2024
3a67136
feat(cli): adding configs commands
odarotto May 3, 2024
32cbff9
refactor(http/configs.py): removing print statement
odarotto May 3, 2024
22d39b9
feat(cli/schedules.py): fixing bad formatting
odarotto May 6, 2024
46b9330
fix(cli): addressing comments on PR
odarotto May 10, 2024
3641f11
Merge branch '29-feat-apply-changes-to-use-workflow-pipelines270' of …
odarotto May 22, 2024
e35e658
test(test_http_context.py): adding tests
odarotto May 23, 2024
d15735b
ci(ci.yml): adding steps to tests job
odarotto May 23, 2024
db3f3ca
ci(ci.yml): changing docker-compose file name
odarotto May 23, 2024
8ffc08b
ci(ci.yml): adding docker login step
odarotto May 23, 2024
f5ab397
feat(cli): adding configs commands
odarotto May 3, 2024
f8b1547
refactor(http/configs.py): removing print statement
odarotto May 3, 2024
25ea648
feat(cli/schedules.py): fixing bad formatting
odarotto May 6, 2024
bb2eda0
fix(cli): addressing comments on PR
odarotto May 10, 2024
7ee34b4
feat(cli): improvements to pipelines and schedules commands
odarotto Apr 30, 2024
834ca8c
fix(cli): addressing comments on PR
odarotto May 10, 2024
371375a
test(test_http_context.py): adding tests
odarotto May 23, 2024
719d85e
ci(ci.yml): adding steps to tests job
odarotto May 23, 2024
41b7c92
ci(ci.yml): changing docker-compose file name
odarotto May 23, 2024
4ed4f67
ci(ci.yml): adding docker login step
odarotto May 23, 2024
c742041
Merge branch '29-feat-apply-changes-to-use-workflow-pipelines270' of …
odarotto May 28, 2024
1fd950a
fix(workflow/utils/read.py): changing active workspace filename
odarotto May 28, 2024
2463711
fix(cli/schedules.py): fixing variable name
odarotto May 29, 2024
b82e437
feat(workflow-dev): added workspace configuration for live system tests
shinybrar May 29, 2024
7c4034a
fix(http): fixed pipelines,schedules and configs to use baseurls with…
shinybrar May 31, 2024
c34761a
fix(workspace-configs): updated workspace configs to point to v2
shinybrar May 31, 2024
546b06a
refactor(test_http_context.py): fixing tests
odarotto Jun 4, 2024
97ce908
Merge branch '29-feat-apply-changes-to-use-workflow-pipelines270' of …
odarotto Jun 4, 2024
fb99ce2
refactor(workspaces/development.yml): adding version suffix to baseurls
odarotto Jun 4, 2024
246abd6
Retrying
odarotto Jun 4, 2024
7e06633
fix(docker-compose-tutorial.yml): settings services to latests version
odarotto Jun 4, 2024
081ef21
fix(docker-compose-tutorial.yml): adding local service
odarotto Jun 4, 2024
3a2954f
fix(http/buckets.py): fixed deposit function
odarotto Jun 4, 2024
4d255a5
Retrying
odarotto Jun 4, 2024
edb0a9f
Merge branch 'main' into 41-bug-bucketsdepositwork-return_ids=true-do…
shinybrar Jun 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions workflow/http/buckets.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Workflow Buckets API."""

from typing import Any, Dict, List, Optional, Union
from urllib.parse import urlencode

from requests.models import Response
from rich.console import Console
Expand Down Expand Up @@ -54,10 +55,10 @@ def deposit(
>>> buckets.deposit([work.payload], return_ids=True)
["5f9b5e1b7e5c4b5eb1b""]
"""
params: Dict[str, Any] = {}
params: Dict[str, Any] = {"return_ids": return_ids}
with self.session as session:
response: Response = session.post(
url=f"{self.baseurl}/work",
url=f"{self.baseurl}/work?{urlencode(params)}",
json=works,
params=params,
timeout=self.timeout,
Expand Down
Loading