EASI-4530 Grb async presentation links card #2958
Conversation
EKS Ingress URLs |
| @@ -84,6 +87,35 @@ function PresentationLinksCard({ | |||
| }); | |||
| }; | |||
|
|
|||
| // External link modal handling | |||
There was a problem hiding this comment.
This handling block is copied from the RTE feature. It isn't great .. but if it needs iteration I think the next worthy step would be to generalize the hook and effect for the whole app, instead of placing a selector scope made from assigning dom refs. (At the time didn't think the site would have so many external links.) For now I think this duplicated instance is okay.
There was a problem hiding this comment.
#2970 introduces an ExternalLinkAndModal component that can be used here. We can update this later, just wanted to point it out for visibility.
There was a problem hiding this comment.
I had referenced Gary to this as he started that work. Thanks.
There was a problem hiding this comment.
- It looks like the "virus scanning in progress" view from the Figma is missing
- Action buttons should be hidden for GRB reviewer view
- I think it's worth adding both this and the virus scanning view to the unit tests
- I noticed a couple things on the mobile view:
- You might want to double check with Zoe on this, but the "Remove all presentation links" button is not displayed on mobile
- The links should all be on separate lines (see screenshot of current state below)
| <> | ||
| {/* Asynchronous presentation links card */} | ||
| <div className="usa-card__container margin-left-0 border-width-1px shadow-2 margin-top-3 margin-bottom-4"> | ||
| <CardHeader> |
There was a problem hiding this comment.
The margin between CardHeader and CardBody needs to be decreased to match the Figma.
| @@ -155,6 +155,21 @@ export const SystemIntake = gql` | |||
| decisionState | |||
| submittedAt | |||
| } | |||
| grbPresentationLinks { | |||
There was a problem hiding this comment.
The transcriptLink field needs to be added to the query and displayed in the same place as the transcriptFileURL field on the card.
| {recordingLink && ( | ||
| <Link | ||
| className="margin-right-2 display-flex flex-align-center" | ||
| href={recordingLink} | ||
| target="_blank" | ||
| > | ||
| {t('asyncPresentation.viewRecording')} | ||
| <Icon.Launch className="margin-left-05" /> | ||
| </Link> | ||
| )} | ||
| {recordingPasscode && ( | ||
| <span className="text-base margin-right-2"> | ||
| {t('asyncPresentation.passcode', { | ||
| passcode: recordingPasscode | ||
| })} | ||
| </span> | ||
| )} | ||
| {transcriptFileStatus === SystemIntakeDocumentStatus.AVAILABLE && | ||
| transcriptFileURL && ( | ||
| <Link |
There was a problem hiding this comment.
Might check with Zoe on this, but I'm pretty sure the recording passcode and transcript link should only display if there is a recording link.
There was a problem hiding this comment.
I just had a call with Zoe to go over something on the presentation links form so I asked her about this. If there is either a recording passcode or transcript but no recording link, display "No recording link available" in place of the link.
I also asked Zoe about this and she said the "Remove all presentation links" button should display on mobile |
EASI-4530
Description
Please keep in mind there is another ticket in this feature for more testing in case there are substantial change requests.
How to test this change
PR Author Checklist
PR Reviewer Guidelines