[EASI-4531] GRB presentation links form

[aterstriep]

EASI-4531

Figma

Description

• Presentation links form to add or edit links
  • /:systemId/grb-review/presentation-links
• Created FileUpload custom component to handle pre-filled file fields
  • This differs slightly from the Figma and displays a "clear file" button instead of "change file" when field has default value. This change was cleared with Zoe.
• Unit tests

How to test this change

I created a testing branch (EASI-4531/grb-presentation-links-form-test) with the branches for #2966 and #2958 merged into this work. Use that branch for testing so that the form mutation works and links are displayed on the "GRB review" admin tab.

• Log in with GOVTEAM job code
• Go to the presentation links form for an IT Gov request (/:systemId/grb-review/presentation-links)
• Test "Add presentation links" form
  • Form button should be disabled unless either the recording link or presentation deck file fields are filled out
  • If you fill the transcript link or document field, that field value should clear if you navigate to the other tab
• After submitting, scroll to the presentation links card and click "Edit presentation links"
• Test "Edit presentation link" form

PR Author Checklist

• I have provided a detailed description of the changes in this PR.
• I have provided clear instructions on how to test the changes in this PR.
• I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

• It's best to pull the branch locally and test it, rather than just looking at the code online!
• When approving a PR, provide a reason why you're approving it
  • e.g. "Approving because I tested it locally and all functionality works as expected"
  • e.g. "Approving because the change is simple and matches the Figma design"
• Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
• Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

[github-actions]

EKS Ingress URLs

• EASi
• Mailcatcher
• Minio Console

[patrickseguraoddball]

After adding a link to a transcript (or an upload), saving, then going back in to edit, the link/upload isn't pre-populated. Additionally, every other hit on the form to edit, the presentation deck file isn't show/empty, even though I uploaded the file. Not sure if this matters or in scope since we are changing the behavior of the presentation deck, but the transcript link should be in scope.

It actually looks like the input value for the presentationDeckFileData and `` are both null despite adding both of those files

Getting a ts error here, didn't seem to be caught in CI/am using the workspace version of TS in the editor.

[patrickseguraoddball]

Might want to add a test for this to ensure that the name gets displayed if it's present

[aterstriep]

Thanks for catching this! I had a unit test for this in the presentation links form but forgot to add unit tests for the actual component. Tests have been added here.

[aterstriep]

Adding details from syncing on this PR for visibility:

After adding a link to a transcript (or an upload), saving, then going back in to edit, the link/upload isn't pre-populated.

This is caused by the transcriptLink field not being included in the GetSystemIntake query, so the data isn't available to populate the field when editing. This should be fixed with changes to #2958.

every other hit on the form to edit, the presentation deck file isn't show/empty, even though I uploaded the file

The mutation currently clears previously uploaded files from the database if the edit form is submitted without touching those fields. See Slack thread for details. The backend mutation is being fixed in #2966, and this will be fixed on the frontend in a separate ticket (EASI-4715).

[patrickseguraoddball]

Mobile sizing seems to be off

[patrickseguraoddball]

LG Thanks for all the help sorting everything out!