-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create directory of example CIFs #161
base: master
Are you sure you want to change the base?
Conversation
From @vaitkus
|
I just forgot to put the values back. I was copying from a Cu loop, and this is a Co loop.
It should have been 'cont'.
It's currently hiding in a PR (#155)
This should definately have an SU associated with it. All three of the things mentioned in the description are able to be refined. |
Could the directory be renamed from |
Ok, I have a few more technical questions about the example:
|
Technically no. I could have sworn I added it in... I'll add it in, my auto-TOPAS output doesn't include a point id.
I'm assuming this is
Yes, this is the intent behind having
Yes. Powder experiments are almost always going to be multi-block, and looking for id-values is kind of governed by https://github.com/COMCIFS/comcifs.github.io/blob/master/accepted/multi-block-principles.md; I've never actually used CIF in a neat one-block-is-one-experiment/structure way. I don't know how to properly denote that using What I am wanting to say with Is there a better way to say that? Maybe |
it isn't necessary; _pd_meas.counts_total has an SU of sqrt(count), and therefore the default weight of 1/SU^2^ is good. No specialist weight scheme was used.
If you want to have a look at some other pdCIFs I made (before I really knew what I was doing), check out https://journals.iucr.org/j/issues/2022/03/00/yr5087/ |
You could make a rule that if there is one loop in a block with one diff_id, then you could autogenerate the point ids. But making too many exceptions isn't really a good thing. |
From COMCIFS/cif_core#430 (comment)
Full CIF file examples of various concepts.
Initial commit for QPA by external standard.