-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ATOM_ANALYTICAL.cif #430
Create ATOM_ANALYTICAL.cif #430
Conversation
Example use of ATOM_ANALYTICAL data items
Thank you for the work! The file is very big and contains many data items from the powder dictionary, thus it cannot be properly validated with this dictionary alone. May I suggest that the full example file be moved to the powder dictionary repository (as a PR there) and this one be trimmed only to the parts relevant for the
Some additional items may be needed for context, but it would be better to limit this example to a single data block with no items from the powder dictionary. As a side-note, I noticed that some items from the powder dictionary have values that violate the current restrictions imposed by that dictionary. I will give a few examples here of the offending items, but I think we should raise a PR with this example file in the powder dictionary repository and continue the full discussion there. Note, I do not claim that the values are bad, just that they do not fit with the current dictionary definitions which may be too limiting or incorrect:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updated example. A comment at the start of the file would be nice (see other example file under /examples).
Also one additional question simply out of my own curiosity. The identified elements make up about 67 %, the loss on ignition at the highest measured temperature for another 11 %, so where do the remaining 78 percent go?
The missing amount is oxygen. The Fe is actually present as Fe2O3 in the fused bead, but is reported as wt% Fe. If you convert to the equivalent oxide, you get 70.18 wt% Fe2O3, which then brings the total to 99.47 wt%. The difference from 100 is a combination of experimental and that the othere elements are also not reported as the "correct" oxide. |
@rowlesmr Thank you for the explanation. |
As requested in #425
Example use of ATOM_ANALYTICAL data items.
As well as the PD_QPA_EXTERNAL_STANDARD data items.