Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge on submission invitations #528

Merged
merged 10 commits into from
Apr 2, 2024
Merged

Badge on submission invitations #528

merged 10 commits into from
Apr 2, 2024

Conversation

SecondFeline
Copy link
Contributor

@SecondFeline SecondFeline commented Mar 31, 2024 •
edited
Loading

Description:

This PR changes the sidebar to include a badge component that appears when users have a requested submission they have yet to submit a video to

Related Issues:

#477

Checklist:

Before submitting this pull request, please make sure of the following:

  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    • Are there representative cases to test the program?
    • Are there tests for edge cases? (empty strings, negatives, infinity, off-by-one errors, etc.)
  • New and existing unit tests pass locally with my changes
  • I have resolved any merge conflicts with the latest master branch.
  • I have labeled my PR
  • I have assigned myself to the PR

Screenshots or Visual Changes (if applicable):

image

image

Documentation

NA

@SecondFeline SecondFeline added the enhancement New feature or request label Mar 31, 2024
@SecondFeline SecondFeline self-assigned this Mar 31, 2024
@SecondFeline SecondFeline linked an issue Mar 31, 2024 that may be closed by this pull request
Badge on submission invitations on dashboard #477
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2024 •
edited
Loading

Component Test Results

Run start date: 4/1/2024, 8:21:39 PM

Duration: 6s

Tests run stats

  • 📚 total tests: 5
  • ✔️ passed: 5
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2024 •
edited
Loading

E2E Test Results

Run start date: 4/1/2024, 8:50:39 PM

Duration: 794s

Tests run stats

  • 📚 total tests: 161
  • ✔️ passed: 161
  • ❌ failed: 0
  • 🔜 skipped: 0
  • ⚠️ skipped by Cypress: 0
  • ❇️ other: 0

Failed tests

Click to reveal

Skipped tests

Click to reveal

Skipped tests by Cypress

Click to reveal

justino599
justino599 requested changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@justino599 justino599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just one nit

cypress/e2e/app/api/dashboard/requestedbadge.cy.ts Outdated Show resolved Hide resolved
justino599
justino599 previously approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@justino599 justino599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hedgemon4 Hedgemon4 self-requested a review April 1, 2024 18:57
@Hedgemon4 Hedgemon4 self-requested a review April 1, 2024 19:19
@SecondFeline SecondFeline requested a review from justino599 April 1, 2024 21:08
Hedgemon4
Hedgemon4 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@Hedgemon4 Hedgemon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good work :)

te-sa
te-sa approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@te-sa te-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@SecondFeline SecondFeline merged commit 2831db3 into master Apr 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hedgemon4 Hedgemon4 Hedgemon4 approved these changes

@te-sa te-sa te-sa approved these changes

@justino599 justino599 justino599 approved these changes

@ketphan02 ketphan02 Awaiting requested review from ketphan02

Assignees

@SecondFeline SecondFeline

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badge on submission invitations on dashboard
4 participants
@SecondFeline @justino599 @te-sa @Hedgemon4