Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial Measure Indexing #133

Closed
manoskary opened this issue Sep 2, 2022 · 0 comments · Fixed by #256
Closed

Partial Measure Indexing #133

manoskary opened this issue Sep 2, 2022 · 0 comments · Fixed by #256
Assignees
@huispaty
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@manoskary
Copy link
Member

In .musicxml partial measures meaning measure line that occur in between proper measure positions (proper = the ones that respect the time signature) get a prefix, i.e. "X1". Inferring the measures in partitura skips treating these measures correctly. A proposition would be to add a prefix and then the measure to which they preceed.
@manoskary manoskary added enhancement New feature or request invalid This doesn't seem right labels Sep 2, 2022
@manoskary manoskary linked a pull request Jun 6, 2023 that will close this issue
Fix for #133 parsing and indexing for partial/irregular measures #256
Merged
CarlosCancino-Chacon added a commit that referenced this issue Jun 7, 2023
@CarlosCancino-Chacon
Merge pull request #256 from CPJKU/partial_measures
093168a 
Fix for issue #133 parsing and indexing for partial/irregular measures. This pull request introduces both name and number fields for `Measure` objects.
@huispaty huispaty closed this as completed Jun 7, 2023
@manoskary manoskary mentioned this issue Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huispaty huispaty

Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #133 parsing and indexing for partial/irregular measures CPJKU/partitura
2 participants
@manoskary @huispaty